Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.2
Affects Version/s: 4.5
Component/s: Assignment, Messages
Labels:

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/HuongNV13/moodle.git
Pull 4.5 Branch:
~~MDL-84042~~-405
Pull 4.5 Diff URL:
https://github.com/HuongNV13/moodle/compare/c58bc49a07...MDL-84042-405
Pull Main Branch:
~~MDL-84042~~-main
Pull Main Diff URL:
https://github.com/HuongNV13/moodle/compare/ab5692acdf...MDL-84042-main
Testing Instructions:
Hide

Automated testing

The PHPUnit notification_helper_test should cover this fairly comprehensively. I have included some manual testing below to demonstrate the scenario that led to this bug discovery is now fixed.

Setup

Log in as Admin.

Go to Site admin -> General -> Location settings.

Set the 'Default timezone' to your local timezone.

Testing scenario 1

Log in as a teacher.

Create a course and enrol a student (student1).

Create an assignment with a due date one day from now.

Log in as student1 and view the assignment page (don't submit it). You will know you are on the right page if you can see the 'Add submission' button.

Run this scheduled task:

php admin/cli/scheduled_task.php --execute=\\mod_assign\\task\\queue_all_assignment_due_soon_notification_tasks

Run cron:

php admin/cli/cron.php

Refresh your page.

Click on the notifications (top of page with 'Bell' icon) .

CONFIRM there is a notification called 'Due on xxxxx ... '
Show
Automated testing The PHPUnit notification_helper_test should cover this fairly comprehensively. I have included some manual testing below to demonstrate the scenario that led to this bug discovery is now fixed. Setup Log in as Admin. Go to Site admin -> General -> Location settings . Set the 'Default timezone' to your local timezone. Testing scenario 1 Log in as a teacher. Create a course and enrol a student (student1). Create an assignment with a due date one day from now. Log in as student1 and view the assignment page (don't submit it). You will know you are on the right page if you can see the 'Add submission' button. Run this scheduled task: php admin/cli/scheduled_task.php --execute=\\mod_assign\\task\\queue_all_assignment_due_soon_notification_tasks Run cron: php admin/cli/cron.php Refresh your page. Click on the notifications (top of page with 'Bell' icon) . CONFIRM there is a notification called 'Due on xxxxx ... '
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84042~~ using repository: https://github.com/davewoloszyn/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84042-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84042-main | CI Job]

_{More information about this report}

Built on: Wed Dec 25 04:47:14 AM UTC 2024
Show
Code verified against automated checks. Checked MDL-84042 using repository: https://github.com/davewoloszyn/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84042-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84042-main | CI Job ] More information about this report Built on: Wed Dec 25 04:47:14 AM UTC 2024
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84042~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17791/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60593/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60594/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84042~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17792/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60595/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60596/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60597/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60598/ App tests (stable app version)

Built on: Wed Dec 25 06:25:19 AM UTC 2024
Show
Launching automatic jobs for branch MDL-84042 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17791/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60593/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60594/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84042 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17792/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60595/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60596/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60597/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60598/ App tests (stable app version) Built on: Wed Dec 25 06:25:19 AM UTC 2024

Story Points:
2
Sprint:
Team Hedgehog 2024 Sprint 4.3, Team Hedgehog 2025 Sprint 1.0

get_users_within_assignment
send_due_soon_notification_to_user
send_overdue_notification_to_user
send_due_digest_notification_to_user

These methods inside mod/assign/classes/notification_helper.php check for user submissions by seeing if a record is returned from get_user_submission.

It was assumed that no record means no submission. That is not correct as I found out using these steps:

Create a course with an activity
Enrol a student into the course
Open up the mdl_assign_submission table and observe no entry for the student yet
Log in as the student and click on the assignment (don't submit or anything else)
Refresh your mdl_assign_submission table and observe the new entry
This can give a false sense of completion

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-84042.png
163 kB
08/Jan/25 1:05 PM

blocks

MDL-83518 SMS notifications: Implement SMS as a new notification method and set up for Assignment notifications

Closed

has a non-specific relationship to

MDL-83878 assignment: Group submission settings locked even with no submissions

Open

Assignee:: David Woloszyn

Reporter:: David Woloszyn

Peer reviewer:: Meirza

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, David Woloszyn, Huong Nguyen, Meirza, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 19/Dec/24 2:49 PM

Updated:: 04/Feb/25 1:58 PM

Resolved:: 09/Jan/25 10:38 PM

Estimated:

Not Specified

Remaining:

Logged:

1d 1h 17m

Details

Automated testing

Setup

Testing scenario 1

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify