-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
4.1.15, 4.5
-
MOODLE_401_STABLE, MOODLE_405_STABLE
If you visit /admin/index.php?cache=1 then it does some rather old and arbitrary security checks. These checks are inconsistent with the security checks
https://github.com/moodle/moodle/blob/main/admin/renderer.php#L298-L318
In particular the development_libs_directories_warning check is wrong because it simply looks to see if the files are present, it doesn't actually curl them (like the proper security check does).
Proposing:
Option A) I would argue that we should just remove this entirely from admin/index.php - there are many other equally or more important checks in the security report which are not exposed here. Many of the security checks are slow so and we should not do them inline.
Option B) We refactor development_libs_directories_warning (and possibly a bunch of these other old checks) so that they are one and the same code as the security checks so they are at least consistent.
Option C) We do B, but take it a step further and run the full suite of security checks, and possible also performance and status checks, via cron, and then just report on any which are not OK here.
- has been marked as being related by
-
MDL-60234 Add possibility to disable admin warning if a development libs directory exists
-
- Closed
-