Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.1.16, 4.3.10, 4.4.6, 4.5.2
Affects Version/s: 4.5
Component/s: Report builder
Labels:
- triaged

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
Migrate to PHPUnit 11
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.1 Branch:
~~MDL-84000~~-401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...paulholden:MDL-84000-401
Pull 4.3 Branch:
~~MDL-84000~~-403
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...paulholden:MDL-84000-403
Pull 4.4 Branch:
~~MDL-84000~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-84000-404
Pull 4.5 Branch:
~~MDL-84000~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-84000-405
Pull Main Branch:
~~MDL-84000~~
Pull Main Diff URL:
https://github.com/paulholden/moodle/compare/MDL-84000~1...MDL-84000
Testing Instructions:
1. Covered by automated tests (PHPUnit)
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-84000~~ using repository: https://github.com/paulholden/moodle/

MOODLE_401_STABLE (0 errors / 0 warnings) [branch: MDL-84000-401 | CI Job]

MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-84000-403 | CI Job]

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84000-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84000-405 | CI Job]

main (0 errors / 1 warnings) [branch: MDL-84000 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: the branch is based off integration.git

Should these errors be fixed?

Built on: Tue Dec 17 08:30:26 AM UTC 2024
Show
Code verified against automated checks with warnings. Checked MDL-84000 using repository: https://github.com/paulholden/moodle/ MOODLE_401_STABLE (0 errors / 0 warnings) [branch: MDL-84000-401 | CI Job ] MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-84000-403 | CI Job ] MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84000-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84000-405 | CI Job ] main (0 errors / 1 warnings) [branch: MDL-84000 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: the branch is based off integration.git Should these errors be fixed? Built on: Tue Dec 17 08:30:26 AM UTC 2024
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84000~~-401

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17743/ PHPUnit (sqlsrv / --testsuite core_reportbuilder_testsuite)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60442/ Behat (NonJS - boost and classic / --tags @core_reportbuilder)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60443/ Behat (Firefox - boost / --tags @core_reportbuilder)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60444/ Behat (Firefox - classic / --tags @core_reportbuilder)

Launching automatic jobs for branch ~~MDL-84000~~-403

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17744/ PHPUnit (sqlsrv / --testsuite core_reportbuilder_testsuite)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60445/ Behat (NonJS - boost and classic / --tags @core_reportbuilder)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60446/ Behat (Firefox - boost / --tags @core_reportbuilder)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60447/ Behat (Firefox - classic / --tags @core_reportbuilder)

Launching automatic jobs for branch ~~MDL-84000~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17745/ PHPUnit (sqlsrv / --testsuite core_reportbuilder_testsuite)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60448/ Behat (NonJS - boost and classic / --tags @core_reportbuilder)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60449/ Behat (Firefox - boost / --tags @core_reportbuilder)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60450/ Behat (Firefox - classic / --tags @core_reportbuilder)

Launching automatic jobs for branch ~~MDL-84000~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17746/ PHPUnit (sqlsrv / --testsuite core_reportbuilder_testsuite)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60451/ Behat (NonJS - boost and classic / --tags @core_reportbuilder)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60452/ Behat (Firefox - boost / --tags @core_reportbuilder)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60453/ Behat (Firefox - classic / --tags @core_reportbuilder)

Launching automatic jobs for branch ~~MDL-84000~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17747/ PHPUnit (sqlsrv / --testsuite core_reportbuilder_testsuite)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60454/ Behat (NonJS - boost and classic / --tags @core_reportbuilder)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60455/ Behat (Firefox - boost / --tags @core_reportbuilder)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60456/ Behat (Firefox - classic / --tags @core_reportbuilder)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60457/ App tests (stable app version) / --tags @core_reportbuilder)

Built on: Tue Dec 17 08:53:59 UTC 2024
Show
Launching automatic jobs for branch MDL-84000 -401 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17743/ PHPUnit (sqlsrv / --testsuite core_reportbuilder_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60442/ Behat (NonJS - boost and classic / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60443/ Behat (Firefox - boost / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60444/ Behat (Firefox - classic / --tags @core_reportbuilder) Launching automatic jobs for branch MDL-84000 -403 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17744/ PHPUnit (sqlsrv / --testsuite core_reportbuilder_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60445/ Behat (NonJS - boost and classic / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60446/ Behat (Firefox - boost / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60447/ Behat (Firefox - classic / --tags @core_reportbuilder) Launching automatic jobs for branch MDL-84000 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17745/ PHPUnit (sqlsrv / --testsuite core_reportbuilder_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60448/ Behat (NonJS - boost and classic / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60449/ Behat (Firefox - boost / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60450/ Behat (Firefox - classic / --tags @core_reportbuilder) Launching automatic jobs for branch MDL-84000 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17746/ PHPUnit (sqlsrv / --testsuite core_reportbuilder_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60451/ Behat (NonJS - boost and classic / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60452/ Behat (Firefox - boost / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60453/ Behat (Firefox - classic / --tags @core_reportbuilder) Launching automatic jobs for branch MDL-84000 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17747/ PHPUnit (sqlsrv / --testsuite core_reportbuilder_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60454/ Behat (NonJS - boost and classic / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60455/ Behat (Firefox - boost / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60456/ Behat (Firefox - classic / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60457/ App tests (stable app version) / --tags @core_reportbuilder) Built on: Tue Dec 17 08:53:59 UTC 2024

Since ~~MDL-66903~~ we can autoload test classes/helpers/etc

To avoid manually include the test helper file in all testcases that want to extend core_reportbuilder_testcase, we should move it to be autoloaded and remove a tiny bit of bloat in all affected tests

Like MDL-83787

has a non-specific relationship to

MDL-66903 Support autoloading of test classes

Closed

has to be done before

MDL-84716 Final removal of deprecated report builder test helper

Open

is blocked by

MDL-83361 Implement time series support for report builder

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Odei Alba

Integrator:: David Carrillo

Tester:: CiBoT

Participants:: CiBoT, David Carrillo, Huong Nguyen, Odei Alba, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 12/Dec/24 5:28 PM

Updated:: 03/Mar/25 9:47 PM

Resolved:: 19/Dec/24 8:26 PM

Estimated:

Remaining:

Logged:

2h 38m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify