Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.2.11, 4.3.9, 4.4.5, 4.5
Component/s: Web Services
Labels:

Affected Branches:
MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/bwalkerl/moodle
Pull 4.4 Branch:
MDL-83996-readonly-false-positive-MOODLE_404_STABLE
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...bwalkerl:MDL-83996-readonly-false-positive-MOODLE_404_STABLE
Pull 4.5 Branch:
MDL-83996-readonly-false-positive-MOODLE_405_STABLE
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...bwalkerl:MDL-83996-readonly-false-positive-MOODLE_405_STABLE
Pull 5.0 Branch:
MDL-83996-readonly-false-positive-MOODLE_500_STABLE
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...bwalkerl:MDL-83996-readonly-false-positive-MOODLE_500_STABLE
Pull Main Branch:
MDL-83996-readonly-false-positive
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...bwalkerl:MDL-83996-readonly-false-positive
Testing Instructions:
Hide

Prerequisites:

Readonly sessions are incompatible with session caches stored in the session, so they need to be changed.

On the cache admin page (/cache/admin.php), scroll to the end of the cache configuration page and click 'Edit mappings'.

Change the session from default session store to default file store.

Kill all sessions from cli (there may be a deprecation warning but it should run)

php admin/cli/kill_all_sessions.php

In config.php, set $CFG->enable_read_only_sessions = true;

In config.php, make sure $CFG->enable_read_only_sessions_debug is not set.

Make sure debug is set to developer - (/admin/settings.php?section=debugging)

On your server, run `tail -f /var/log/error.log` where /var/log/error.log is the file your PHP error logs to go.

Test a service that will modify the session

Using mod_assign_list_participants as an example:

Login to Moodle as an site admin

Create a new test course

Create a new assignment activity using the defaults.

Open the assignment activity and click on "Grade"

Confirm no error related to READ_ONLY_SESSION is displayed in error.log (Before fix: a message would be logged).
Show
Prerequisites: Readonly sessions are incompatible with session caches stored in the session, so they need to be changed. On the cache admin page (/cache/admin.php), scroll to the end of the cache configuration page and click 'Edit mappings'. Change the session from default session store to default file store. Kill all sessions from cli (there may be a deprecation warning but it should run) php admin/cli/kill_all_sessions.php In config.php, set $CFG->enable_read_only_sessions = true; In config.php, make sure $CFG->enable_read_only_sessions_debug is not set. Make sure debug is set to developer - (/admin/settings.php?section=debugging) On your server, run `tail -f /var/log/error.log` where /var/log/error.log is the file your PHP error logs to go. Test a service that will modify the session Using mod_assign_list_participants as an example: Login to Moodle as an site admin Create a new test course Create a new assignment activity using the defaults. Open the assignment activity and click on "Grade" Confirm no error related to READ_ONLY_SESSION is displayed in error.log (Before fix: a message would be logged).
Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-83996 using repository: https://github.com/bwalkerl/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83996-readonly-false-positive-MOODLE_404_STABLE | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83996-readonly-false-positive-MOODLE_405_STABLE | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83996-readonly-false-positive | CI Job]

_{More information about this report}

Built on: Thu 12 Dec 2024 06:48:19 AM UTC
Show
Code verified against automated checks. Checked MDL-83996 using repository: https://github.com/bwalkerl/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83996-readonly-false-positive-MOODLE_404_STABLE | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83996-readonly-false-positive-MOODLE_405_STABLE | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83996-readonly-false-positive | CI Job ] More information about this report Built on: Thu 12 Dec 2024 06:48:19 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch MDL-83996-readonly-false-positive-MOODLE_404_STABLE

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17710/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60313/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60314/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-83996-readonly-false-positive-MOODLE_405_STABLE

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17711/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60315/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60316/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-83996-readonly-false-positive

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17712/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60317/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60318/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60319/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60320/ App tests (stable app version)

Built on: Thu Dec 12 08:25:24 AM UTC 2024
Show
Launching automatic jobs for branch MDL-83996 -readonly-false-positive-MOODLE_404_STABLE https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17710/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60313/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60314/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83996 -readonly-false-positive-MOODLE_405_STABLE https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17711/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60315/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60316/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83996 -readonly-false-positive https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17712/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60317/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60318/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60319/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60320/ App tests (stable app version) Built on: Thu Dec 12 08:25:24 AM UTC 2024

I've been going through error logs and have noticed a large number of read only session changed errors from multiple lib/ajax services that haven't defined 'readonlysession' (which defaults to false). One such example:

Script /lib/ajax/service.php?sesskey=xxx&info=mod_assign_list_participants defined READ_ONLY_SESSION but the following SESSION attributes were changed: $SESSION->mod_assign_useridlist

From my testing this only occurs when $CFG->enable_read_only_sessions is true but $CFG->enable_read_only_sessions_debug is not.

It appears to be a regression from ~~MDL-81192~~, which added a check in restart_with_write_lock() so that self::$requireslockdebug is only altered if $CFG->enable_session_lock_debug is true.

has been marked as being related by

MDL-81052 getnavbranch defined READ_ONLY_SESSION but attempts to change $SESSION->activegroup

Open

Assignee:: Benjamin Walker

Reporter:: Benjamin Walker

Peer reviewer:: Brendan Heywood

Participants:: Benjamin Walker, Brendan Heywood, CiBoT, Jun Pataleta

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 12/Dec/24 12:42 PM

Updated:: 29/May/25 3:01 PM

Details

Prerequisites:

Test a service that will modify the session

Description

Attachments

Issue Links

Activity

People

Dates

Clockify