Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.5, 5.0.1
Affects Version/s: 4.1.11, 4.5, 5.0
Component/s: Tags
Labels:

Affected Branches:
MOODLE_401_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/meirzamoodle/moodle.git
Pull 4.5 Branch:
~~MDL-83943~~-405
Pull 4.5 Diff URL:
https://github.com/meirzamoodle/moodle/compare/6dd1f61866...MDL-83943-405
Pull 5.0 Branch:
~~MDL-83943~~-500
Pull 5.0 Diff URL:
https://github.com/meirzamoodle/moodle/compare/6999197243...MDL-83943-500
Pull Main Branch:
~~MDL-83943~~-main
Pull Main Diff URL:
https://github.com/meirzamoodle/moodle/compare/9242f9619a...MDL-83943-main
Testing Instructions:
Hide

Login as admin.

Create 12 users. The users have the same interest/tag "bicycle".

Create a course

Assign 6 of the 12 users to the course. Make sure the six users do not have consecutive IDs.

Login as one of the assigned users.

Navigate to http://wwwroot/tag/index.php?tc=1&tag=bicycle

VERIFY that there are only two pages.

VERIFY that the first page has five users.

VERIFY that the second page only has one user.

VERIFY that the second page doesn't have a "more" link.
Show
Login as admin. Create 12 users. The users have the same interest/tag "bicycle". Create a course Assign 6 of the 12 users to the course. Make sure the six users do not have consecutive IDs. Login as one of the assigned users. Navigate to http://wwwroot/tag/index.php?tc=1&tag=bicycle VERIFY that there are only two pages. VERIFY that the first page has five users. VERIFY that the second page only has one user. VERIFY that the second page doesn't have a "more" link.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83943~~ using repository: https://github.com/meirzamoodle/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83943-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83943-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83943-main | CI Job]

_{More information about this report}

Built on: Mon Mar 17 06:32:21 UTC 2025
Show
Code verified against automated checks. Checked MDL-83943 using repository: https://github.com/meirzamoodle/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83943-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83943-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83943-main | CI Job ] More information about this report Built on: Mon Mar 17 06:32:21 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83943~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19236/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65760/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65761/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65762/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-83943~~-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19237/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65763/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65764/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65765/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-83943~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19238/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65766/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65767/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65768/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65769/ App tests (stable app version) / complete)

Built on: Fri May 9 06:45:41 UTC 2025
Show
Launching automatic jobs for branch MDL-83943 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19236/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65760/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65761/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65762/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-83943 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19237/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65763/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65764/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65765/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-83943 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19238/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65766/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65767/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65768/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65769/ App tests (stable app version) / complete) Built on: Fri May 9 06:45:41 UTC 2025

Story Points:
2
Sprint:
Team Dragons 2025 Sprint 1.2, Team Dragons 2025 Sprint 1.3, Team Hedgehogs 2025 Sprint 2.0

Patch for MDL-82963 fixes the reported security issue but introduces a strange UI:

in the case when you can only see profiles of 5 people out of dozens who have the tag (i.e. you can only see teachers but not other users profiles) the pagination looks very weird. First page may have 0 users and the next page would have 3, and the next is empty again but the "More..." link is displayed.
if there are some users tagged with the given tag but you do not have permissions to see any of them, you may see an empty block with the header "User interests", for other tag areas the header is not shown if it is empty (for example, if you tag a course in a category that user can not browse)

I'm marking it as security issue because it is linked to other security issues but it is just a normal bug

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 10 Passed -- (Main)MDL-83943.png
15/May/25 2:53 PM
85 kB
Kim Jared Lucas
(1) 7 Passed -- (Main)MDL-83943.png
15/May/25 2:53 PM
61 kB
Kim Jared Lucas
(1) 8 Passed -- (Main)MDL-83943.png
15/May/25 2:53 PM
85 kB
Kim Jared Lucas

Assignee:: Meirza

Reporter:: Marina Glancy

Peer reviewer:: Raquel Ortega

Integrator:: David Woloszyn

Tester:: Kim Jared Lucas

Participants:: CiBoT, David Woloszyn, Huong Nguyen, Jun Pataleta, Kim Jared Lucas, Marina Glancy, Meirza, Raquel Ortega

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 06/Dec/24 8:56 PM

Updated:: 06/Jun/25 4:29 PM

Resolved:: 16/May/25 1:44 PM

Estimated:

Remaining:

Logged:

2d 1h 31m

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify