Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-83942

Allow to make a default tag collection not searchable

XMLWordPrintable

    • MOODLE_405_STABLE
    • MOODLE_500_STABLE
    • Hide

      (Note, behat test for this exact scenario is already included in the patch)

      1. Add some tags anywhere, for example, tags for the courses or user interests in the profile
      2. Navigate to /tag/search.php and make sure you can see these tags
      3. As admin go to Site administration>Apperance>Manage tags
      4. Make sure you can make the Default collection not searchable by clicking on the "tick" icon in the column searchable
      5. Navigate to /tag/search.php and make sure you can not see these tags
      6. Try other options, create more collections, some searchable and some not, move tag areas to one collection or another. Make sure /tag/search.php always shows only tags from searchable collections
      Show
      (Note, behat test for this exact scenario is already included in the patch) Add some tags anywhere, for example, tags for the courses or user interests in the profile Navigate to /tag/search.php and make sure you can see these tags As admin go to Site administration>Apperance>Manage tags Make sure you can make the Default collection not searchable by clicking on the "tick" icon in the column searchable Navigate to /tag/search.php and make sure you can not see these tags Try other options, create more collections, some searchable and some not, move tag areas to one collection or another. Make sure /tag/search.php always shows only tags from searchable collections

      I originally marked this issue as a security because of the links to the other security issues, however those are now closed and this is more of a security improvement.

      Specifically in Workplace we want to change the defaults so no tags are displayed in the tag cloud on /tag/search.php as a default.

      Not a lot of people even know about the existence of this page and since we changed navigation in theme Boost there are no direct links to this page. However it exists, it does not require any capabilities and it also can be found by:

      • add a user interest in your profile
      • view your profile and click on the tag with your interest
      • now you see a page that shows all entities on the site that are marked with this tag (most likely only your own profile). There are permissions checks that make sure that you do not see things that you do not have access to
      • on this page in the breadcrumb you can navigate to the "Tags" page which is /tag/search.php
      • this page by default displays all tags in all tag areas ever used, without any permission checks, this can be courses, user interests, etc.

      Admin can go to "Site administration > Appearance > Manage tags" and create additional tag collections, mark them as not searchable and move some sensitive tag areas there.

      However admin can not make the "Default collection" not searchable.

      Why I want to make this improvement:
      In Workplace we use tags a lot and we also have multi-tenancy, showing the list of all tags to all users is really not desirable. We would like to automatically make "Default collection" not searchable when a Workplace site is installed. Admin should be able to change this default later. I also assume that 99% people don't even know about this page, so it brings no benefit but has potential security considerations.

      I would recommend to make any tag areas non-searchable by default in LMS as well

            marina Marina Glancy
            marina Marina Glancy
            Paul Holden Paul Holden
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            CiBoT CiBoT
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours, 2 minutes
                5h 2m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.