Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.1
Affects Version/s: 4.5.1, 5.0
Component/s: AI
Labels:

Affected Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/davewoloszyn/moodle.git
Pull 4.5 Branch:
~~MDL-83836~~-405
Pull 4.5 Diff URL:
https://github.com/davewoloszyn/moodle/compare/485130d7c5...MDL-83836-405
Pull Main Branch:
~~MDL-83836~~-main
Pull Main Diff URL:
https://github.com/davewoloszyn/moodle/compare/269a8a8a1b...MDL-83836-main
Testing Instructions:
Hide

Setup

Login as admin

Go to Site admin -> General -> AI -> AI providers

Enabled 'OpenAI API Provider'

Click to the 'settings' link

Enter in valid credentials to ensure the provider will work correctly (reach out if you need credentials).

Enable 'Summarise text' action.

Go to Site admin -> General -> AI -> AI placements

Enable 'Course Assistance Placement'

Create a course

Create a page resource with some text in it (any text will do).

Enrol a student (s1) into the course

Testing cancelling policy acceptance

Log in as s1

Go to the page resource you created

Click the 'Summarise' button

When prompted with the policy, click 'Decline'

CONFIRM that the AI drawer closes

Click the 'Summarise' button again

CONFIRM you are prompted with the AI policy again.

Click 'Accept and continue'

Test cancelling request

Go to the page resource you created

Click the 'Summarise' button

While the AI is generating, click the 'Cancel' button

CONFIRM the drawer is closed and the request is cancelled.
Show
Setup Login as admin Go to Site admin -> General -> AI -> AI providers Enabled 'OpenAI API Provider' Click to the 'settings' link Enter in valid credentials to ensure the provider will work correctly (reach out if you need credentials). Enable 'Summarise text' action. Go to Site admin -> General -> AI -> AI placements Enable 'Course Assistance Placement' Create a course Create a page resource with some text in it (any text will do). Enrol a student (s1) into the course Testing cancelling policy acceptance Log in as s1 Go to the page resource you created Click the 'Summarise' button When prompted with the policy, click 'Decline' CONFIRM that the AI drawer closes Click the 'Summarise' button again CONFIRM you are prompted with the AI policy again. Click 'Accept and continue' Test cancelling request Go to the page resource you created Click the 'Summarise' button While the AI is generating, click the 'Cancel' button CONFIRM the drawer is closed and the request is cancelled.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83836~~ using repository: https://github.com/davewoloszyn/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83836-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83836-main | CI Job]

_{More information about this report}

Built on: Thu 28 Nov 2024 11:54:38 PM UTC
Show
Code verified against automated checks. Checked MDL-83836 using repository: https://github.com/davewoloszyn/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83836-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83836-main | CI Job ] More information about this report Built on: Thu 28 Nov 2024 11:54:38 PM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83836~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17578/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59859/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59860/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83836~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17579/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59861/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59862/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59863/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59864/ App tests (stable app version)

Built on: Thu Nov 28 10:25:33 PM UTC 2024
Show
Launching automatic jobs for branch MDL-83836 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17578/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59859/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59860/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83836 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17579/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59861/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59862/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59863/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59864/ App tests (stable app version) Built on: Thu Nov 28 10:25:33 PM UTC 2024

Story Points:
1
Sprint:
Team Hedgehog 2024 Sprint 4.2
Issue size:
Small

Discovered while developing for ~~MDL-82942~~.

There are two cases where the JS selectors are misconfigured. This breaks two things:

When the user is prompted to accept or decline the policy in the AI drawer, clicking the 'Decline' doesn't do anything.
When generating content, click 'Cancel' does not actually do anything.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83836.png
1.17 MB
05/Dec/24 1:56 PM

blocks

MDL-82942 AI: Course placement - Explain

Closed

Assignee:: David Woloszyn

Reporter:: David Woloszyn

Peer reviewer:: Meirza

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, David Woloszyn, Huong Nguyen, Meirza, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 28/Nov/24 12:48 PM

Updated:: 09/Dec/24 10:17 AM

Resolved:: 06/Dec/24 12:47 AM

Estimated:

Not Specified

Remaining:

Logged:

2h 58m

Details

Setup

Testing cancelling policy acceptance

Test cancelling request

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify