Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.2
Affects Version/s: 4.5
Component/s: Authentication
Labels:
- ci
- mebis
- patch
- triaged

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/PhMemmel/moodle.git
Pull 4.5 Branch:
~~MDL-83822~~-MOODLE_405_STABLE
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...PhMemmel:moodle:MDL-83822-MOODLE_405_STABLE
Pull Main Branch:
~~MDL-83822~~-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...PhMemmel:moodle:MDL-83822-main
Testing Instructions:
Hide

Setup requirements

PHPRedis: https://github.com/phpredis/phpredis

Setup Redis instance. If you haven't installed it yet, please consider to use docker with the below command

docker run --name redis -p 6379:6379 -d redis:alpine

Testing

Open config.php and add the below codes:

$CFG->session_handler_class = '\core\session\redis';

$CFG->session_redis_host = '127.0.0.1';

Install plugin from https://github.com/phmemmel/moodle-local_test.git , branch ~~MDL-83822~~-main

Upgrade your Moodle instance.

In your teminal, run the below command

php local/test/cli/check_session_exists.php

Verify that you do not see an error.

Run another command

php admin/cli/scheduled_task.php --execute=\\local_test\\task\\session_exists_task

Verify that you do not see an error.
Show
Setup requirements PHPRedis: https://github.com/phpredis/phpredis Setup Redis instance. If you haven't installed it yet, please consider to use docker with the below command docker run --name redis -p 6379 : 6379 -d redis:alpine Testing Open config.php and add the below codes: $CFG->session_handler_class = '\core\session\redis' ; $CFG->session_redis_host = '127.0.0.1' ; Install plugin from https://github.com/phmemmel/moodle-local_test.git , branch MDL-83822 -main Upgrade your Moodle instance. In your teminal, run the below command php local/test/cli/check_session_exists.php Verify that you do not see an error. Run another command php admin/cli/scheduled_task.php --execute=\\local_test\\task\\session_exists_task Verify that you do not see an error.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83822~~ using repository: https://github.com/PhMemmel/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83822-MOODLE_405_STABLE | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83822-main | CI Job]

_{More information about this report}

Built on: Fri 29 Nov 2024 06:59:56 AM UTC
Show
Code verified against automated checks. Checked MDL-83822 using repository: https://github.com/PhMemmel/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83822-MOODLE_405_STABLE | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83822-main | CI Job ] More information about this report Built on: Fri 29 Nov 2024 06:59:56 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83822~~-MOODLE_405_STABLE

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17583/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59878/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59879/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83822~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17584/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59880/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59881/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59882/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59883/ App tests (stable app version)

Built on: Fri Nov 29 08:25:19 AM UTC 2024
Show
Launching automatic jobs for branch MDL-83822 -MOODLE_405_STABLE https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17583/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59878/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59879/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83822 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17584/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59880/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59881/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59882/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59883/ App tests (stable app version) Built on: Fri Nov 29 08:25:19 AM UTC 2024

To reproduce:

Set {$CFG->session_handler_class = '\core\session\redis';} in {config.php}
Install plugin from {[https://github.com/phmemmel/moodle-local_test.git]}
, branch
{MDL-83822-main}
Run {php local/test/cli/check_session_exists.php}, see error "Call to a member function hmget() on null"
Run {php admin/cli/scheduled_task.php --execute=\\local_test\\task session_exists_task}
, see same

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83822.png
120 kB
05/Feb/25 9:58 AM

has been marked as being related by

MDL-83847 PR only: MDL-83822 - redis session handler: session_exists fails when used outside session

Closed

Assignee:: PhMemmel

Reporter:: PhMemmel

Peer reviewer:: Meirza

Integrator:: Safat Shahin

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Huong Nguyen, Meirza, PhMemmel, Ron Carl Alfon Yu, Safat Shahin

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 27/Nov/24 12:03 AM

Updated:: 07/Feb/25 12:20 AM

Resolved:: 07/Feb/25 12:20 AM

Estimated:

Not Specified

Remaining:

Logged:

34m

Details

Setup requirements

Testing

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify