Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 5.0
Component/s: Navigation
Labels:
- ci
- triaged

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-83786~~-main
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/269a8a8a1b...MDL-83786-main?w=1
Testing Instructions:
Hide

Run composer install

Run mdk run dev (or similar to enable dev mode)

Edit database and remove the navfilter configuration option:

DELETE FROM mdl_config WHERE name = 'navfilter';

Purge Moodle caches

php admin/cli/purge_caches.php

Navigate to your site

Switch to the Classic theme

Confirm you weren't shown a Whoops error handler
Show
Run composer install Run mdk run dev (or similar to enable dev mode) Edit database and remove the navfilter configuration option: DELETE FROM mdl_config WHERE name = 'navfilter'; Purge Moodle caches php admin/cli/purge_caches.php Navigate to your site Switch to the Classic theme Confirm you weren't shown a Whoops error handler
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83786~~ using repository: https://github.com/andrewnicols/moodle.git

main (0 errors / 0 warnings) [branch: MDL-83786-main | CI Job]

_{More information about this report}

Built on: Fri 22 Nov 2024 10:16:17 AM UTC
Show
Code verified against automated checks. Checked MDL-83786 using repository: https://github.com/andrewnicols/moodle.git main (0 errors / 0 warnings) [branch: MDL-83786-main | CI Job ] More information about this report Built on: Fri 22 Nov 2024 10:16:17 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83786~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17486/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59573/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59574/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59575/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59576/ App tests (stable app version)

Built on: Fri Nov 22 10:26:26 UTC 2024
Show
Launching automatic jobs for branch MDL-83786 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17486/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59573/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59574/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59575/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59576/ App tests (stable app version) Built on: Fri Nov 22 10:26:26 UTC 2024

The core_renderer had some new code introduced by ~~MDL-63219~~ recently:

        if (!empty($CFG->navfilter && !empty($CFG->stringfilters))) {

The first empty has a mis-placed paren.
There are two occurrences of this.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 6 Passed -- (Main)MDL-83786.png
27/Nov/24 1:01 PM
253 kB
Kim Jared Lucas

is a regression caused by

MDL-63219 Add support for Moodle filters to Primary/Custom Menus

Closed

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Paul Holden

Integrator:: Safat Shahin

Tester:: Kim Jared Lucas

Participants:: Andrew Lyons, CiBoT, Huong Nguyen, Kim Jared Lucas, Paul Holden, Safat Shahin

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 22/Nov/24 8:27 AM

Updated:: 29/Nov/24 8:27 PM

Resolved:: 29/Nov/24 8:27 PM

Estimated:

Not Specified

Remaining:

Logged:

46m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify