Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 5.0
Component/s: Course
Labels:

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
Cleanup pre 4.0 course code
Pull from Repository:
https://github.com/laurentdavid/moodle.git
Pull Main Branch:
~~MDL-83764~~-main
Pull Main Diff URL:
https://github.com/laurentdavid/moodle/compare/7a318d5c85...MDL-83764-main
Testing Instructions:
Hide

Login as admin.

Turn moodle development debugging on (Site Administration > Debugging > Debug messages > DEVELOPER)

Create a course C1

View the course page

Copy the externservercourse.php file in <rootinstall>/course

Reload the page

Ensure that there is the following deprecation message
Show
Login as admin. Turn moodle development debugging on (Site Administration > Debugging > Debug messages > DEVELOPER) Create a course C1 View the course page Copy the externservercourse.php file in <rootinstall>/course Reload the page Ensure that there is the following deprecation message
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83764~~ using repository: https://github.com/laurentdavid/moodle.git

main (0 errors / 0 warnings) [branch: MDL-83764-main | CI Job]

_{More information about this report}

Built on: Mon Feb 24 06:08:07 AM UTC 2025
Show
Code verified against automated checks. Checked MDL-83764 using repository: https://github.com/laurentdavid/moodle.git main (0 errors / 0 warnings) [branch: MDL-83764-main | CI Job ] More information about this report Built on: Mon Feb 24 06:08:07 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83764~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18358/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62832/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62833/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62834/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62835/ App tests (stable app version) / complete)

Built on: Wed Feb 26 07:23:11 UTC 2025
Show
Launching automatic jobs for branch MDL-83764 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18358/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62832/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62833/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62834/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62835/ App tests (stable app version) / complete) Built on: Wed Feb 26 07:23:11 UTC 2025

Story Points:
1
Sprint:
HQ 2025 Planning I1 Moppies

In ~~MDL-83473~~ a new before_course_view hooks was introduced. This hook replaces the old /course/externservercourse.php but leaves a legacy hook listener for backward compatibility.

However, keeping the "/course/externservercourse.php" inclusion generates more problems than solutions: it is a third-party file, but it is located in a completely random place in the core; it is globally scoped and expects many undocumented global variables...

Everything that can be done in externservercourse could be easily coded in a hook listener from a local or a theme plugin.

This issue goals are:

Add a deprecation message to core_courseformat\hook_listener::before_course_view method
Create a final deprecation issue in the 6.0 deprecation epic (MDL-78075) and add @todo tags to the current listener.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

externservercourse.php
0.1 kB
26/Feb/25 8:15 PM
MDL-83764.png
136 kB
27/Feb/25 9:45 AM
screenshot-1.png
536 kB
26/Feb/25 8:17 PM

has a non-specific relationship to

MDL-83839 Final deprecation of externservercourse.php

Open

has been marked as being related by

MDL-83587 Forwarding of enrollments for course redirections

Closed

is blocked by

MDL-83473 Replacement of extern_server_course function in course/view.php by hooks api

Closed

mentioned in: Page Loading...

Assignee:: Laurent David

Reporter:: Ferran Recio

Peer reviewer:: Carlos Escobedo

Integrator:: Sara Arjona (@sarjona)

Tester:: Ron Carl Alfon Yu

Participants:: Carlos Escobedo, CiBoT, Ferran Recio, Laurent David, Ron Carl Alfon Yu, Sara Arjona (@sarjona), Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 20/Nov/24 12:02 AM

Updated:: 11/Apr/25 6:14 PM

Resolved:: 28/Feb/25 12:55 AM

Estimated:

Remaining:

Logged:

1d 2h 13m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify