Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.5, 4.5.1
Affects Version/s: 4.0 regressions, 4.1.14, 4.3.8, 4.5
Component/s: Questions
Labels:
- ci
- regression
- triaged

Affected Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle
Pull 4.4 Branch:
~~MDL-83710~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-83710-404
Pull 4.5 Branch:
~~MDL-83710~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83710-405
Pull Main Branch:
~~MDL-83710~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83710
Testing Instructions:
Hide

Log in as admin

Navigate to Reports > Question instances in site administration

Change Question type to "Missing question type placeholder"

Press Get the report

Confirm there is no DML exception
Show
Log in as admin Navigate to Reports > Question instances in site administration Change Question type to "Missing question type placeholder" Press Get the report Confirm there is no DML exception
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-83710~~ using repository: https://github.com/paulholden/moodle

MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-83710-404 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-83710~~-404 branch at https://github.com/paulholden/moodle has not been rebased recently (>20 days ago).

MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-83710-405 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-83710~~-405 branch at https://github.com/paulholden/moodle has not been rebased recently (>20 days ago).

main (0 errors / 0 warnings) [branch: MDL-83710 | CI Job]

Should these errors be fixed?

Built on: Fri 22 Nov 2024 05:21:58 PM UTC
Show
Code verified against automated checks with warnings. Checked MDL-83710 using repository: https://github.com/paulholden/moodle MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-83710-404 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-83710 -404 branch at https://github.com/paulholden/moodle has not been rebased recently (>20 days ago). MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-83710-405 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-83710 -405 branch at https://github.com/paulholden/moodle has not been rebased recently (>20 days ago). main (0 errors / 0 warnings) [branch: MDL-83710 | CI Job ] Should these errors be fixed? Built on: Fri 22 Nov 2024 05:21:58 PM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83710~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17350/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59189/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59190/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83710~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17351/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59191/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59192/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83710~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17352/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59193/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59194/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59195/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59196/ App tests (stable app version)

Built on: Thu Nov 14 08:25:21 PM UTC 2024
Show
Launching automatic jobs for branch MDL-83710 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17350/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59189/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59190/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83710 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17351/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59191/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59192/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83710 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17352/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59193/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59194/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59195/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59196/ App tests (stable app version) Built on: Thu Nov 14 08:25:21 PM UTC 2024

Description: When navigating to the Question Instances report and choosing "Missing question type placeholder" from the dropdown, an error is returned

Scope: Limited to the Question Instances report and specifically the Missing question type placeholder

Replication steps:

Navigate to /report/questioninstances/?qtype=missingtype
Note the error that appears

Text of the error:
ERROR: Incorrect number of query parameters. Expected 26, got 25.

More information about this error
Debug info:
Error code: invalidqueryparam
Stack trace: * line 957 of /lib/dml/moodle_database.php: dml_exception thrown

line 1399 of /lib/dml/mysqli_native_moodle_database.php: call to moodle_database->fix_sql_params()
line 92 of /report/questioninstances/index.php: call to mysqli_native_moodle_database->get_records_sql()

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83710.png
272 kB
05/Dec/24 10:11 AM

is a regression caused by

MDL-71696 Add question versions

Closed

Assignee:: Paul Holden

Reporter:: Hannah Killian

Peer reviewer:: Luca Bösch

Integrator:: Jun Pataleta

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Hannah Killian, Jun Pataleta, Luca Bösch, Paul Holden, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Created:: 14/Nov/24 4:44 AM

Updated:: 06/Dec/24 12:48 AM

Resolved:: 06/Dec/24 12:48 AM

Estimated:

Not Specified

Remaining:

Logged:

41m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify