Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.4.5, 4.5.1
Component/s: Forum
Labels:
- ci
- patch

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_500_STABLE
Pull from Repository:
https://github.com/PhilippImhof/moodle.git
Pull 4.3 Branch:
~~MDL-83697~~_403
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...PhilippImhof:moodle:MDL-83697_403
Pull 4.4 Branch:
~~MDL-83697~~_404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...PhilippImhof:moodle:MDL-83697_404
Pull 4.5 Branch:
~~MDL-83697~~_405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...PhilippImhof:moodle:MDL-83697_405
Pull Main Branch:
~~MDL-83697~~_main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...PhilippImhof:moodle:MDL-83697_main
Testing Instructions:
Hide

Go to any Forum in any Moodle course.

Click "Add Discussion topic".

Set "Subject" field to "Test".

In the "Message" field, switch to HTML source view (depending on editor). Enter the following:
<p>
<img style="border: 1px solid #000000; border-radius: 10px;" src="x" alt="x">
</p>

Click "Save changes".

Verify that the image border has rounded corners.
Show
Go to any Forum in any Moodle course. Click "Add Discussion topic". Set "Subject" field to "Test". In the "Message" field, switch to HTML source view (depending on editor). Enter the following: <p> <img style="border: 1px solid #000000; border-radius: 10px;" src="x" alt="x"> </p> Click "Save changes". Verify that the image border has rounded corners.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83697~~ using repository: https://github.com/PhilippImhof/moodle.git

MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-83697_403 | CI Job]

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83697_404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83697_405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83697_main | CI Job]

_{More information about this report}

Built on: Wed 13 Nov 2024 11:15:51 AM UTC
Show
Code verified against automated checks. Checked MDL-83697 using repository: https://github.com/PhilippImhof/moodle.git MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-83697_403 | CI Job ] MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83697_404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83697_405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83697_main | CI Job ] More information about this report Built on: Wed 13 Nov 2024 11:15:51 AM UTC

Currently, the HTML Purifier will filter out CSS properties like border-radius from forum posts or glossary entries.

As per this GitHub issue, we could simply add $config->set('CSS.Proprietary', true); when setting up the purifier in weblib.php. This would allow "safe, proprietary CSS values"; there is a detailed list available in the source.

IMHO it would make sense to do that.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 6 Passed -- (Main)MDL-83697.png
58 kB
21/Mar/25 1:14 PM

Assignee:: Philipp Imhof

Reporter:: Philipp Imhof

Peer reviewer:: Luca Bösch

Integrator:: Glyn (Mathew) May

Tester:: Kim Jared Lucas

Participants:: Andrew Lyons, CiBoT, Glyn (Mathew) May, Huong Nguyen, Kim Jared Lucas, Luca Bösch, Philipp Imhof

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 12/Nov/24 4:18 PM

Updated:: 21/Mar/25 11:26 PM

Resolved:: 21/Mar/25 11:26 PM

Estimated:

Not Specified

Remaining:

Logged:

1h 47m

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify