Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.1
Affects Version/s: 4.5 regressions, 4.5
Component/s: Report builder, Tasks
Labels:
- ci
- regression
- triaged

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.5 Branch:
~~MDL-83686~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83686-405
Pull Main Branch:
~~MDL-83686~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83686
Testing Instructions:
Hide

Note: testing works better on a pre-existing site with lots of task log data (run cron a few times)

Log in as admin

Navigate to Server > Tasks > Task logs in site administration

Confirm each of the listed task runs are clickable, and take you to each individual task run

Navigate to Reports from user menu

Create new report from Task logs report source with "Include default setup" option unchecked

In the editor, add the following columns:

Task log > Name

Task log > Result

Set aggregation for the Result column to "Sum"

Confirm each task name has correctly summed result column value (typically greater than 1, assuming run multiple times)
Show
Note: testing works better on a pre-existing site with lots of task log data (run cron a few times) Log in as admin Navigate to Server > Tasks > Task logs in site administration Confirm each of the listed task runs are clickable, and take you to each individual task run Navigate to Reports from user menu Create new report from Task logs report source with "Include default setup" option unchecked In the editor, add the following columns: Task log > Name Task log > Result Set aggregation for the Result column to "Sum" Confirm each task name has correctly summed result column value (typically greater than 1, assuming run multiple times)
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83686~~ using repository: https://github.com/paulholden/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83686-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83686 | CI Job]

_{More information about this report}

Built on: Wed 13 Nov 2024 09:18:49 AM UTC
Show
Code verified against automated checks. Checked MDL-83686 using repository: https://github.com/paulholden/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83686-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83686 | CI Job ] More information about this report Built on: Wed 13 Nov 2024 09:18:49 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83686~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17312/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58991/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58992/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83686~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17313/ PHPUnit (sqlsrv) --> unrelated

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59068/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58994/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59069/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58996/ App tests (stable app version)

Built on: Mon Nov 11 06:25:19 PM UTC 2024
Show
Launching automatic jobs for branch MDL-83686 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17312/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58991/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58992/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83686 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17313/ PHPUnit (sqlsrv) --> unrelated https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59068/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58994/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59069/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58996/ App tests (stable app version) Built on: Mon Nov 11 06:25:19 PM UTC 2024

This is a regression from ~~MDL-82175~~, which I've noticed while integrating MDL-82173

The change in the former issue has broken aggregation of the Task log > Name column in custom reports (we can no longer group by it, because it now includes the .id table field):

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83686.png
532 kB
04/Dec/24 9:46 AM
Screenshot 2024-11-11 at 15-16-09 Task logs (#82173) Integration Master.png
85 kB
11/Nov/24 11:21 PM

blocks

MDL-82173 Improve task reports and logs for custom data, task id, and exposing errors

Development in progress

is a regression caused by

MDL-82175 Get rid of the task log popup window and make it a normal page

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: David Carrillo

Integrator:: Sara Arjona (@sarjona)

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, David Carrillo, Paul Holden, Ron Carl Alfon Yu, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 11/Nov/24 11:18 PM

Updated:: 06/Dec/24 12:48 AM

Resolved:: 06/Dec/24 12:48 AM

Estimated:

Not Specified

Remaining:

Logged:

1h 17m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify