Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.5, 4.5.1
Affects Version/s: 4.2 regressions, 4.4 regressions, 4.5 regressions, 5.0
Component/s: Course
Labels:
- ci
- partner
- partner-Praxis
- patch
- praxis
- release_notes
- triaged

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/praxisdigital/moodle
Pull 4.4 Branch:
~~MDL-83658~~-MOODLE_404_STABLE
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/99b5729824524e0bdc6a64ff1b0e4423d1d4b37a...praxisdigital:moodle:MDL-83658-MOODLE_404_STABLE
Pull 4.5 Branch:
~~MDL-83658~~-MOODLE_405_STABLE
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/acff633e392763a5d61723257efa1bd2ade463a2...praxisdigital:moodle:MDL-83658-MOODLE_405_STABLE
Pull Main Branch:
~~MDL-83658~~-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/d015c4c21331831c73e7ca102eb9334bf20f25c4...praxisdigital:moodle:MDL-83658-main
Testing Instructions:
Hide

Setup:

Go to Site administration > Development > Debugging

Set debug to "DEVELOPER: extra Moodle debug messages for developers"

Enable debugdisplay

Create a new "format_topics" aka "Custom sections" course

Test:

Go to created course front page

Click the "CourseEditor{courseid}" reactive instance button

Click the "reset panel" button to clear the logs

Scroll up/down to the nearest section/cm to trigger a state update for the "course.pageItem" variable.

Verify a log has been outputted to the "State events log" textarea

Try scrolling up/down again to trigger a new state update

Verify a new log has been outputted to the "State events log" textarea
Show
Setup: Go to Site administration > Development > Debugging Set debug to "DEVELOPER: extra Moodle debug messages for developers" Enable debugdisplay Create a new "format_topics" aka "Custom sections" course Test: Go to created course front page Click the "CourseEditor{courseid}" reactive instance button Click the "reset panel" button to clear the logs Scroll up/down to the nearest section/cm to trigger a state update for the "course.pageItem" variable. Verify a log has been outputted to the "State events log" textarea Try scrolling up/down again to trigger a new state update Verify a new log has been outputted to the "State events log" textarea
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83658~~ using repository: https://github.com/praxisdigital/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83658-MOODLE_404_STABLE | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83658-MOODLE_405_STABLE | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83658-main | CI Job]

_{More information about this report}

Built on: Wed 20 Nov 2024 10:39:09 AM UTC
Show
Code verified against automated checks. Checked MDL-83658 using repository: https://github.com/praxisdigital/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83658-MOODLE_404_STABLE | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83658-MOODLE_405_STABLE | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83658-main | CI Job ] More information about this report Built on: Wed 20 Nov 2024 10:39:09 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83658~~-MOODLE_404_STABLE

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17434/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59463/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59464/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83658~~-MOODLE_405_STABLE

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17435/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59465/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59466/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83658~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17436/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59467/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59468/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59469/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59470/ App tests (stable app version)

Built on: Wed Nov 20 12:30:23 PM UTC 2024
Show
Launching automatic jobs for branch MDL-83658 -MOODLE_404_STABLE https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17434/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59463/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59464/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83658 -MOODLE_405_STABLE https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17435/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59465/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59466/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83658 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17436/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59467/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59468/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59469/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59470/ App tests (stable app version) Built on: Wed Nov 20 12:30:23 PM UTC 2024

The reactive debug panel does not log a transaction, if the events fired are exactly the same as the previous ones. This makes the tool pretty useless when developing new features for reactive instances, since you can't trust it actually show the fired events

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83658.png
354 kB
27/Nov/24 1:18 PM

blocks

MDL-83673 Add throttle to the course page scroll event handling and prevent unnecessary updates

Closed

Assignee:: Frederik Milling Pytlick

Reporter:: Frederik Milling Pytlick

Peer reviewer:: Ferran Recio

Integrator:: Amaia Anabitarte

Tester:: Ron Carl Alfon Yu

Participants:: Amaia Anabitarte, Andrew Lyons, CiBoT, Ferran Recio, Frederik Milling Pytlick, Huong Nguyen, Ron Carl Alfon Yu

Votes:: 6 Vote for this issue

Watchers:: 8 Start watching this issue

Created:: 07/Nov/24 7:24 PM

Updated:: 03/Dec/24 4:18 PM

Resolved:: 29/Nov/24 8:28 PM

Estimated:

Not Specified

Remaining:

Logged:

3h 12m

Details

Setup:

Test:

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify