-
Bug
-
Resolution: Fixed
-
Minor
-
4.3.8, 4.4.4
-
MOODLE_403_STABLE, MOODLE_404_STABLE
-
MOODLE_404_STABLE, MOODLE_405_STABLE
-
MDL-83653_404 -
MDL-83653_405 -
This can be reproduced with any file-picker, but I choose to use edit profile:
To test this you need to be able to edit code in your dev site, to simulate an error.
- Edit repository/draftfiles_ajax.php to add the line throw new dml_write_exception('Error deleting file'); just after the line case 'delete': (which is currently like 82 in main).
- Go to a form with a file-picker, e.g. User menu -> Profile, then click 'Edit profile'.
- Scroll down to the User picture -> New picture and drag in a file (of the right type. This needs to be a JPEG).
- Click on the uploaded file, then click the 'Delete' button in the pop-up.
- Click 'Yes' in the Confirm popup.
- Verify that the error you added in Step 1 above is reported in a standard Moodle error pop-up.
This can be reproduced with any file-picker, but I choose to use edit profile: To test this you need to be able to edit code in your dev site, to simulate an error. Edit repository/draftfiles_ajax.php to add the line throw new dml_write_exception('Error deleting file'); just after the line case 'delete': (which is currently like 82 in main). Go to a form with a file-picker, e.g. User menu -> Profile, then click 'Edit profile'. Scroll down to the User picture -> New picture and drag in a file (of the right type. This needs to be a JPEG). Click on the uploaded file, then click the 'Delete' button in the pop-up. Click 'Yes' in the Confirm popup. Verify that the error you added in Step 1 above is reported in a standard Moodle error pop-up. -
Code verified against automated checks. 
Checked
MDL-83653using repository: https://github.com/timhunt/moodle.git
MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83653_404 | CI Job]- MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83653_405 | CI Job]
- main (0 errors / 0 warnings) [branch: MDL-83653 | CI Job]
More information about this report
Built on: Tue 26 Nov 2024 12:39:22 AM UTC
Code verified against automated checks. Checked MDL-83653 using repository: https://github.com/timhunt/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83653_404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83653_405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83653 | CI Job ] More information about this report Built on: Tue 26 Nov 2024 12:39:22 AM UTC -
This can be reproduced with any file-picker:
- Edit repository/draftfiles_ajax.php to add the line throw new dml_write_exception('Error deleting file'); just after the line case 'delete':.
- Go to a form with a file-picker, e.g. upload photo when editing your profile (https://qa.moodledemo.net/user/edit.php?id=3&returnto=profile - logged in as teacher)
- Drag in one file (of the right type. This needs to be a JPEG).
- Click on the uploaded file, then click the 'Delete' button in the pop-up.
- Click 'Yes' in the Confirm popup.
Expected result: The error we added at Step 1. above should be displayed in a pop-up.
Actual result: The error is ignored. (But, if you inspect the Ajax request in your browser consold, you can see that the error was sent back from PHP to JavaScript, only to be ignored there.)
