Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.5, 4.5.1
Affects Version/s: 4.2 regressions, 4.4.5, 4.5.1
Component/s: Administration
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.4 Branch:
~~MDL-83641~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-83641-404
Pull 4.5 Branch:
~~MDL-83641~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83641-405
Pull Main Branch:
~~MDL-83641~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83641
Testing Instructions:
Hide

Setup

Log in as admin

Navigate to Users > Permissions > Define roles in site administration

Edit the Manager role

Select User for Context types where this role may be assigned and save

Create a new cohort in the system context

Create a new cohort in a category context

Test

Navigate to Users > Permissions > Assign user roles to cohort in site administration

Open the Select cohorts autocomplete form field

Confirm both the system cohort and category cohort are listed
Show
Setup Log in as admin Navigate to Users > Permissions > Define roles in site administration Edit the Manager role Select User for Context types where this role may be assigned and save Create a new cohort in the system context Create a new cohort in a category context Test Navigate to Users > Permissions > Assign user roles to cohort in site administration Open the Select cohorts autocomplete form field Confirm both the system cohort and category cohort are listed
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83641~~ using repository: https://github.com/paulholden/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83641-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83641-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83641 | CI Job]

_{More information about this report}

Built on: Mon 02 Dec 2024 05:09:07 PM UTC
Show
Code verified against automated checks. Checked MDL-83641 using repository: https://github.com/paulholden/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83641-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83641-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83641 | CI Job ] More information about this report Built on: Mon 02 Dec 2024 05:09:07 PM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83641~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17602/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59945/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59946/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83641~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17603/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59947/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59948/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83641~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17604/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59949/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59950/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59951/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59952/ App tests (stable app version)

Built on: Mon Dec 2 04:25:23 PM UTC 2024
Show
Launching automatic jobs for branch MDL-83641 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17602/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59945/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59946/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83641 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17603/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59947/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59948/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83641 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17604/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59949/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59950/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59951/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59952/ App tests (stable app version) Built on: Mon Dec 2 04:25:23 PM UTC 2024

In the version 4.1 of moodle in administration->users->Assign user roles to cohort

we can choose cohort in category level, not anymore (4.3).

in 4.1 the form assign_role_cohort use the tool_lp form for searching cohort by passing data-includes = 'all' so we search all cohorts.

in 4.3 we don't use tool_lp/form-cohort-selector anymore instead we use tool_lp/form-cohort-selector and "includes" param is "parents" so it will search only cohorts in system level.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 3 Passed -- (Main)MDL-83641.png
68 kB
05/Dec/24 1:49 PM

is a regression caused by

MDL-61458 Remove the tool_lp/form-cohort-selector for using the cohort form element instead

Closed

is duplicated by

MDL-81846 Improve the core/form-cohort-selector allowing to receive custom includes

Closed

Assignee:: Paul Holden

Reporter:: Issam Taboubi

Peer reviewer:: Salem Saidi

Integrator:: Huong Nguyen

Tester:: Kim Jared Lucas

Participants:: CiBoT, Huong Nguyen, Issam Taboubi, Kim Jared Lucas, Paul Holden, Salem Saidi, Stevani Andolo

Votes:: 2 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 06/Nov/24 12:58 AM

Updated:: 17/Dec/24 5:05 PM

Resolved:: 06/Dec/24 12:48 AM

Estimated:

Not Specified

Remaining:

Logged:

Details

Setup

Test

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify