Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.4.1, 4.5
Component/s: Accessibility toolkit
Labels:
- ci
- release_notes

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/junpataleta/moodle.git
Pull 4.4 Branch:
~~MDL-83635~~-404
Pull 4.4 Diff URL:
https://github.com/junpataleta/moodle/compare/1c7ac7057b...MDL-83635-404
Pull 4.5 Branch:
~~MDL-83635~~-405
Pull 4.5 Diff URL:
https://github.com/junpataleta/moodle/compare/89e6f737cc...MDL-83635-405
Pull Main Branch:
~~MDL-83635~~-main
Pull Main Diff URL:
https://github.com/junpataleta/moodle/compare/07881a5772...MDL-83635-main
Testing Instructions:

Hide

Covered by unit tests.

Show
Covered by unit tests.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83635~~ using repository: https://github.com/junpataleta/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83635-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83635-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83635-main | CI Job]

_{More information about this report}

Built on: Tue 05 Nov 2024 08:18:42 AM UTC
Show
Code verified against automated checks. Checked MDL-83635 using repository: https://github.com/junpataleta/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83635-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83635-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83635-main | CI Job ] More information about this report Built on: Tue 05 Nov 2024 08:18:42 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83635~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18133/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61957/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61958/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83635~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18134/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61959/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61960/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83635~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18135/ PHPUnit (sqlsrv) --> unrelated random failure

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61961/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61962/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61963/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61964/ App tests (stable app version)

Built on: Mon Feb 3 10:30:36 AM UTC 2025
Show
Launching automatic jobs for branch MDL-83635 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18133/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61957/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61958/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83635 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18134/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61959/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61960/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83635 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18135/ PHPUnit (sqlsrv) --> unrelated random failure https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61961/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61962/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61963/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61964/ App tests (stable app version) Built on: Mon Feb 3 10:30:36 AM UTC 2025

Story Points:
1
Sprint:
Team Hedgehogs 2025 Sprint 1.1

The img_alt_is_too_long check uses strlen(), which can result in a larger number when the alt text contains multibyte strings. We should be using core_text::strlen() to count the alt text length properly, regardless of whether they are multibyte or not.

Discovered while testing

MDL-83634 The severity of the Brickfield img_alt_is_too_long check seems incorrect

Closed

has to be done before

MDL-83634 The severity of the Brickfield img_alt_is_too_long check seems incorrect

Closed

Assignee:: Jun Pataleta

Reporter:: Jun Pataleta

Peer reviewer:: Meirza

Integrator:: Safat Shahin

Tester:: CiBoT

Participants:: CiBoT, Huong Nguyen, Jun Pataleta, Meirza, Safat Shahin, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 05/Nov/24 2:50 PM

Updated:: 07/Feb/25 1:00 PM

Resolved:: 07/Feb/25 12:20 AM

Estimated:

Remaining:

Logged:

1h 8m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify