Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.5
Component/s: Themes
Labels:

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/lostrogit/moodle.git
Pull 4.4 Branch:
~~MDL-83593~~_404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...lostrogit:moodle:MDL-83593_404
Pull 4.5 Branch:
~~MDL-83593~~_405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...lostrogit:moodle:MDL-83593_405
Pull Main Branch:
~~MDL-83593~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...lostrogit:moodle:MDL-83593
Testing Instructions:
Hide

Covered by automated testing

Manual testing

Log in as admin

Go to Site administration > Appearance > Logos

Make sure there isn't image uploaded on Compact logo (logocompact) setting.

Click on Home link

Reduce the browser size to table / mobile view ( < 768 px )

Click on the navbar toggler (the hamburger menu)

Confirm the "Short name for site" is shown in the menu header.

Make sure you can click on this menu header and it lands to the configured home.

Go to Site administration > Appearance > Logos

Upload an image to the Compact logo (logocompact) setting.

Save the changes

Confirm the image uploaded is shown responsively in the menu header.

Make sure you can click on this menu header and it lands to the configured home.

Set the following setting $THEME->removedprimarynavitems = ['home']; in the config.php file of the current theme.

Reload the page.

Confirm that "Home" isn't shown as part of the drawer options.

Confirm you can land to the configured home page using the "sitename/logo".
Show
Covered by automated testing Manual testing Log in as admin Go to Site administration > Appearance > Logos Make sure there isn't image uploaded on Compact logo (logocompact) setting. Click on Home link Reduce the browser size to table / mobile view ( < 768 px ) Click on the navbar toggler (the hamburger menu) Confirm the "Short name for site" is shown in the menu header. Make sure you can click on this menu header and it lands to the configured home. Go to Site administration > Appearance > Logos Upload an image to the Compact logo (logocompact) setting. Save the changes Confirm the image uploaded is shown responsively in the menu header. Make sure you can click on this menu header and it lands to the configured home. Set the following setting $THEME->removedprimarynavitems = ['home'] ; in the config.php file of the current theme. Reload the page. Confirm that " Home " isn't shown as part of the drawer options. Confirm you can land to the configured home page using the "sitename/logo".
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-83593~~ using repository: https://github.com/lostrogit/moodle.git

MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-83593_404 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/1), gherkin (0/0),

MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-83593_405 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/1), gherkin (0/0),

main (0 errors / 1 warnings) [branch: MDL-83593 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/1), gherkin (0/0),

Should these errors be fixed?

Built on: Tue 10 Dec 2024 08:28:54 AM UTC
Show
Code verified against automated checks with warnings. Checked MDL-83593 using repository: https://github.com/lostrogit/moodle.git MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-83593_404 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/1) , gherkin (0/0) , MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-83593_405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/1) , gherkin (0/0) , main (0 errors / 1 warnings) [branch: MDL-83593 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/1) , gherkin (0/0) , Should these errors be fixed? Built on: Tue 10 Dec 2024 08:28:54 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83593~~_404

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60360/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60361/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60362/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-83593~~_405

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60363/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60364/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60365/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-83593~~

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60366/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60367/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60368/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60369/ App tests (stable app version) / complete)

Built on: Sun Dec 15 11:09:15 PM UTC 2024
Show
Launching automatic jobs for branch MDL-83593 _404 https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60360/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60361/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60362/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-83593 _405 https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60363/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60364/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60365/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-83593 https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60366/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60367/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60368/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60369/ App tests (stable app version) / complete) Built on: Sun Dec 15 11:09:15 PM UTC 2024

Story Points:
1
Sprint:
WP Sprint 2024-I4.2 (Clones), WP Sprint 2024-I4.3 (Clones)

MWP doesn't have the link in the navbar to /?redirect=0 anymore (Start). If you select "Home" at defaulthomepage: /admin/settings.php?section=navigation, the logo on the top left leads you to /?redirect=0.

But when yo go to mobile view the navbar becomes a drawer. In the drawer the logo is not a link anymore, but just an image. This way, users can't navigate back to the Start.

My solution would be that MWP will have the link to Start again and that there will be an option which links will be shown in the navbar.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

aabtn-compactlogo.png
21 kB
17/Dec/24 5:07 PM
aabtn-sitename.png
15 kB
17/Dec/24 5:07 PM
MDL-83593.png
586 kB
18/Dec/24 1:14 PM
with-compact-logo.png
118 kB
17/Dec/24 5:06 PM
without-compact-logo.png
125 kB
17/Dec/24 5:06 PM

is duplicated by

MDL-84221 No easy way to go to site home on mobile devices

Closed

Assignee:: Carlos Castillo

Reporter:: Jaron Cohen

Peer reviewer:: Pedro Jordao

Integrator:: Jun Pataleta

Tester:: Ron Carl Alfon Yu

Participants:: Carlos Castillo, CiBoT, Jaron Cohen, Jun Pataleta, Marina Glancy, Pedro Jordao, Rafael Lechugo, Ron Carl Alfon Yu, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 11 Start watching this issue

Created:: 09/Oct/24 8:10 PM

Updated:: 07/Feb/25 1:40 PM

Resolved:: 19/Dec/24 8:27 PM

Estimated:

Not Specified

Remaining:

Logged:

4d 2h 35m

Details

Manual testing

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify