Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.5, 4.5.1
Affects Version/s: 4.4.4
Component/s: Reports
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_404_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/sammarshallou/moodle.git
Pull 4.4 Branch:
~~MDL-83584~~-m404
Pull 4.4 Diff URL:
https://github.com/sammarshallou/moodle/compare/MOODLE_404_STABLE...MDL-83584-m404
Pull 4.5 Branch:
~~MDL-83584~~-m405
Pull 4.5 Diff URL:
https://github.com/sammarshallou/moodle/compare/MOODLE_405_STABLE...MDL-83584-m405
Pull Main Branch:
~~MDL-83584~~-main
Pull Main Diff URL:
https://github.com/sammarshallou/moodle/compare/main...MDL-83584-main
Testing Instructions:
Hide

As there is no functional behaviour change (except if the server has a large number e.g. million+ user accounts), this test just confirms that the existing behaviour still works OK.

Create a test course, with group mode set to 'Separate groups'.

Create if necessary and enrol via Participants tab three different test accounts, which I'm referring to as 't1', 't2', and 't3', to the course. t1 and t3 should be 'Non-editing teacher', t2 should be 'Teacher'.

Create 2 groups on the course via Participants / Groups, G1 and G2.

Using Add/remove users button, Add t1 to group G1 and t2 to group G2.

Log in as each user t1, t2, t3 in turn and visit the course.

Also log in as admin and visit the course if you didn't already.

Log in as t1 and go to the log report for the course (Reports / Logs). Get logs by clicking Get these logs.

EXPECTED: You should only see events from user t1 in the log report.

Log in as t2 and go to the log report for the course. Get logs.

EXPECTED: You should see events from users t1, t2, t3, and admin.

Select group G1 in the All groups dropdown and get logs again.

EXPECTED: You should now only see events from user t1.

Log in as t3 and go to the log report for the course. Get logs.

EXPECTED: You should now only see events from admin and t3 (everyone who isn't in a group).
Show
As there is no functional behaviour change (except if the server has a large number e.g. million+ user accounts), this test just confirms that the existing behaviour still works OK. Create a test course, with group mode set to 'Separate groups'. Create if necessary and enrol via Participants tab three different test accounts, which I'm referring to as 't1', 't2', and 't3', to the course. t1 and t3 should be 'Non-editing teacher', t2 should be 'Teacher'. Create 2 groups on the course via Participants / Groups , G1 and G2. Using Add/remove users button, Add t1 to group G1 and t2 to group G2. Log in as each user t1, t2, t3 in turn and visit the course. Also log in as admin and visit the course if you didn't already. Log in as t1 and go to the log report for the course ( Reports / Logs ). Get logs by clicking Get these logs . EXPECTED: You should only see events from user t1 in the log report. Log in as t2 and go to the log report for the course. Get logs. EXPECTED: You should see events from users t1, t2, t3, and admin. Select group G1 in the All groups dropdown and get logs again. EXPECTED: You should now only see events from user t1. Log in as t3 and go to the log report for the course. Get logs. EXPECTED: You should now only see events from admin and t3 (everyone who isn't in a group).
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83584~~ using repository: https://github.com/sammarshallou/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83584-m404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83584-m405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83584-main | CI Job]

_{More information about this report}

Built on: Wed 06 Nov 2024 02:28:27 PM UTC
Show
Code verified against automated checks. Checked MDL-83584 using repository: https://github.com/sammarshallou/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83584-m404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83584-m405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83584-main | CI Job ] More information about this report Built on: Wed 06 Nov 2024 02:28:27 PM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83584~~-m404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17277/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58872/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58873/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58874/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-83584~~-m405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17278/ PHPUnit (sqlsrv / complete) --> known random

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58875/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58876/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58877/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-83584~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17279/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58878/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58879/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58880/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58881/ App tests (stable app version) / complete)

Built on: Thu Nov 7 11:06:57 AM UTC 2024
Show
Launching automatic jobs for branch MDL-83584 -m404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17277/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58872/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58873/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58874/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-83584 -m405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17278/ PHPUnit (sqlsrv / complete) --> known random https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58875/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58876/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58877/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-83584 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17279/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58878/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58879/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58880/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58881/ App tests (stable app version) / complete) Built on: Thu Nov 7 11:06:57 AM UTC 2024

When using report_log, in the following scenario:

Course is set to separate groups
User has access all groups permission
User has not selected a specific group to filter

Then there is a point where it (effectively) obtains a list of all the users who are not in any group on the course, and also all the users who are in any group on the course, and uses this in-memory list to filter the log results.

Because this list is actually all users on the entire system, (a) it is pointless to filter by it, and (b) it can use a lot of memory and potentially (depending on other factors) exceed PHP memory limit and crash out, on a system with a large number of a user accounts. We had this issue reported on our live system.

I think this list of users to filter is useful if:

a) A specific group has been selected

b) User does not have access all groups and will be restricted to seeing users in the groups they belong to

When this is not the case it just wastes time and memory. I will update the code to avoid using it in that scenario.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 10 Passed -- (Main)MDL-83584.png
05/Dec/24 1:13 PM
243 kB
Kim Jared Lucas
(1) 7 Passed -- (Main)MDL-83584.png
05/Dec/24 1:13 PM
144 kB
Kim Jared Lucas
(1) 8 Passed -- (Main)MDL-83584.png
05/Dec/24 1:13 PM
176 kB
Kim Jared Lucas
(1) 9 Passed -- (Main)MDL-83584.png
05/Dec/24 1:13 PM
196 kB
Kim Jared Lucas

Assignee:: Sam Marshall

Reporter:: Sam Marshall

Peer reviewer:: Katie Ransom

Integrator:: Amaia Anabitarte

Tester:: Kim Jared Lucas

Participants:: Amaia Anabitarte, CiBoT, Huong Nguyen, Katie Ransom, Kim Jared Lucas, Sam Marshall, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 29/Oct/24 5:04 PM

Updated:: 10/Mar/25 8:56 PM

Resolved:: 06/Dec/24 12:48 AM

Estimated:

Not Specified

Remaining:

Logged:

1d 1h 9m

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify