Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.5, 4.5.1
Affects Version/s: 4.4.5, 4.5
Component/s: Unit tests, User management
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/marinaglancy/moodle
Pull 4.4 Branch:
~~MDL-83504~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...marinaglancy:moodle:MDL-83504-404
Pull 4.5 Branch:
~~MDL-83504~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...marinaglancy:moodle:MDL-83504-405
Pull Main Branch:
~~MDL-83504~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...marinaglancy:MDL-83504
Testing Instructions:

Hide

only automated tests are affected. If you run added tests without core changes, they should fail

Show
only automated tests are affected. If you run added tests without core changes, they should fail
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83504~~ using repository: https://github.com/marinaglancy/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83504-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83504-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83504 | CI Job]

_{More information about this report}

Built on: Mon 21 Oct 2024 05:08:29 PM UTC
Show
Code verified against automated checks. Checked MDL-83504 using repository: https://github.com/marinaglancy/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83504-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83504-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83504 | CI Job ] More information about this report Built on: Mon 21 Oct 2024 05:08:29 PM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83504~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17073/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58130/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58131/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83504~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17074/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58132/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58133/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83504~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17075/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58134/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58135/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58136/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58137/ App tests (stable app version)

Built on: Mon Oct 21 04:25:58 PM UTC 2024
Show
Launching automatic jobs for branch MDL-83504 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17073/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58130/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58131/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83504 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17074/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58132/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58133/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83504 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17075/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58134/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58135/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58136/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58137/ App tests (stable app version) Built on: Mon Oct 21 04:25:58 PM UTC 2024

There is a static variable in \core\user::$preferencescache that needs to be reset between unittests because it may contain some values that are different between tests.

For example, $preferences['user_home_page_preference'] has a list of choices that are populated from a hook and can be different depending on the enabled functionality.

Other plugins may also implement *_user_preferences callback using dynamic list of options

will help resolve

MDL-63824 Static caches not reset between tests and causing nightmares

Open

Assignee:: Marina Glancy

Reporter:: Marina Glancy

Peer reviewer:: Paul Holden

Integrator:: Huong Nguyen

Tester:: CiBoT

Participants:: CiBoT, Huong Nguyen, Marina Glancy, Paul Holden

Votes:: 1 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 21/Oct/24 10:18 PM

Updated:: 12/Nov/24 6:06 PM

Resolved:: 25/Oct/24 10:33 AM

Estimated:

Remaining:

Logged:

4h 6m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify