Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-83496

Launching LtiSubmissionReviewRequest is broken for some launch container types

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.1.15, 4.5.1
    • LTI External tool
    • None
    • MOODLE_401_STABLE, MOODLE_405_STABLE

      For some launch container types, trying to open a student's LTI submission for review as an instructor does not work. Instead of a LtiSubmissionReviewRequest Moodle makes an LtiResourceLinkRequest.

      For example, with launch container 'Existing window', when I click on a link to a student submission in a user report, Moodle opens `/mod/lti/view.php?id=1292947&action=gradeReport&user=174015`, which then redirects to `/mod/lti/launch.php?id=1292947`. The `action=gradeReport&user=174015` part, which triggers LtiSubmissionReviewRequest has disappeared.

      A similar issue happens with container type 'New window'. Moodle redirects to `/mod/lti/launch.php?id=1239690&triggerview=0&action=gradeReport&user=212559`, where the escaping of ampersands as `&` breaks the URL parsing.

      There is no such issue with container types 'Embed' and 'Embed, without blocks'.

      I suspect the cause is some faulty/incomplete launch URL handling logic in `/mod/lti/view.php`.

            Unassigned Unassigned
            feldrinh FeldrinH
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.