Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-83452

Extraneous add_body_class() in mod_assign

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • 4.4.7, 4.5.3
    • 4.4.5, 4.5
    • Assignment

      assign->view() has:

              if (empty($action)) {
      		 
                  $PAGE->add_body_class('limitedwidth');
      		 
              }

      But when $action is empty it falls through to the end of a long if/else if/else where – since Moodle 4.0 (MDL-74031) – $PAGE->add_body_class('limitedwidth') is called again:

              } else {
      		 
                  $PAGE->add_body_class('limitedwidth');
      		 
                  ⋮
      		 
              }

        1. MDL-83452.png
          220 kB
          Ron Carl Alfon Yu

            leonstr Leon Stringer
            leonstr Leon Stringer
            Alex Yeung Alex Yeung
            Glyn (Mathew) May Glyn (Mathew) May
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 21 minutes
                1h 21m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.