Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.5, 4.5.1
Affects Version/s: 4.4.5
Component/s: Enrolments
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_404_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.4 Branch:
~~MDL-83443~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-83443-404
Pull 4.5 Branch:
~~MDL-83443~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83443-405
Pull Main Branch:
~~MDL-83443~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83443
Testing Instructions:
Hide

Log in as admin

Create a user

Create a course

Navigate to course role renaming

Enter "Learner" for Your word for 'Student'

Navigate to course enrolment methods

Edit the Manual enrolments method

Change custom welcome message:

Hi {$a->firstname}, you are enrolled in the course {$a->coursename} as a {$a->courserole}

Manually enrol test user as a Learner on the course

Confirm test user received an email informing them they were enrolled as a Learner
Show
Log in as admin Create a user Create a course Navigate to course role renaming Enter "Learner" for Your word for 'Student' Navigate to course enrolment methods Edit the Manual enrolments method Change custom welcome message: Hi {$a->firstname}, you are enrolled in the course {$a->coursename} as a {$a->courserole} Manually enrol test user as a Learner on the course Confirm test user received an email informing them they were enrolled as a Learner
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83443~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/16978/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57842/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57843/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83443~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/16979/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57844/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57845/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83443~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/16980/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57846/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57847/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57848/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57849/ App tests (stable app version)

Built on: Mon Oct 14 08:25:22 AM UTC 2024
Show
Launching automatic jobs for branch MDL-83443 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/16978/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57842/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57843/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83443 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/16979/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57844/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57845/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83443 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/16980/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57846/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57847/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57848/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57849/ App tests (stable app version) Built on: Mon Oct 14 08:25:22 AM UTC 2024

While looking at ~~MDL-83432~~, I noticed we are sending the role shortname property in the welcome message

This is non-optimal in English as we use the actual role name in the UI (not its shortname, which would be confusing), and untranslatable in non-English languages where the shortname would make even less sense

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83443.png
99 kB
17/Oct/24 1:27 PM

Discovered while testing

MDL-83432 Manual enrolment course welcome message role placeholder always displays "student"

Closed

is a regression caused by

MDL-4188 Send course welcome message for manual and self enrolments

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Laurent David

Integrator:: Jun Pataleta

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Jun Pataleta, Laurent David, Paul Holden, Ron Carl Alfon Yu

Votes:: 1 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 11/Oct/24 9:05 PM

Updated:: 06/Dec/24 6:12 PM

Resolved:: 18/Oct/24 9:37 PM

Estimated:

Not Specified

Remaining:

Logged:

1h 19m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify