Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-83415

Remove set_module_viewed() call from the behat generator for mod_feedback

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.2.10, 4.1.14, 4.3.8, 4.4.4, 4.5
    • Feedback
    • MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE

      While playing with the Generator tool, I realised it's failing in some situations when Debug display is enabled.

      Steps to reproduce

      1. Login as admin.
      2. Go to Site administration > Development > Create testing scenarios
      3. Upload gitpod-basic-scenario_testing.feature

      Expected behaviour

      No error is displayed and the course is created with the expected content. If Debug display is disabled, this error is not displayed. It's also working as expected with the file is uploaded using the CLI tool.

       

      Current behaviour

      The following error is displayed:

       

      Looking at the code, the mod_feedback generator is calling set_module_viewed when creating responses, which seems weird (no other plugin is calling this method in their generator). 

            Unassigned Unassigned
            sarjona Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.