Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-83378

Remove option to disable slash arguments (slashargs)

XMLWordPrintable

    • MOODLE_500_STABLE
    • MDL-83378-401
    • MDL-83378-403
    • MDL-83378-404
    • MDL-83378-405
    • MDL-83378-main
    • Hide

      4.1 to 4.5 testing

      1. Open config.php
      2. Add $CFG->slasharguments = false;
      3. Login as admin.
      4. Navigate to Site Administration > Server > Environment
      5. Select 4.5 in Moodle version
      6. Verify that you will not see slasharguments warning in the Other checks section
      7. Select any version lower than 4.5
      8. Verify that you will see slasharguments warning in the Other checks section

      Main only testing

      Manual install testing

      1. Create a new moodle instance, but don't install it yet.
      2. Pull the patch
      3. Install the instance
      4. Navigate to the Site Admin and search for "slasharguments".
      5. Verify the option is not exist.

      Manual upgrade testing

      1. Do not apply the patch.
      2. Navigate to the Site Admin and search for "slasharguments".
      3. Verify the option is there.
      4. Apply the patch.
      5. Run the upgrade.
      6. Navigate to the Site Admin and search for "slasharguments".
      7. Verify the option is gone.

      Mod Scorm testing

      1. After install/upgrade, add the following in the config.php (this will verify that even if there is any forced config for this, it won't be used anymore): $CFG->slasharguments = 0;
      2. Navigate to any course page.
      3. Add a new Scorm activity.
      4. In the form, VERIFY there is no alert "WARNING: slash arguments is disabled on this site and objects may not function as expected!"
      5. Specify the name with any name
      6. Add the MDL-62640_scorm_sample.zip to Package file
      7. Save it
      8. VERIFY you can preview the scorm package without any errors.

      Mod Wiki testing

      1. After install/upgrade, add the following in the config.php (this will verify that even if there is any forced config for this, it won't be used anymore): $CFG->slasharguments = 0;
      2. Navigate to any course page.
      3. Add a new Wiki activity.
      4. Specify the wiki name and first page name with any name
      5. Set NWiki format in the the Format section
      6. Click the Save and display button
      7. At the New page form, click the create page button.
      8. Select Files at the dropdown
      9. Click the Edit wiki files
      10. Add the attached image sample.png 
      11. Click the Save the changes button
      12. Select Edit at the dropdown
      13. In the Insert an image dropdown, select the sample.png
      14. Click the Save button
      15. VERIFY you can see the image without any errors.

      Filter Algebra testing

      Note: This is blocked by MDL-83043.

      1. Login as admin
      2. Navigate to Site admin >  Plugins > Filters > Manage Filters
      3. Turn ON the Algebra notation filter and apply to Content
      4. Navigate to WWWROOT/filter/algebra/algebradebug.php
      5. VERIFY there are only 5 steps to show algebraic expression
      6. Edit your profile
      7. In the description type the text "@@sin(z)/(x^2+y^2)@@" (without double quote)
      8. Click the Update profile button
      9. VERIFY you will see Algebraic Notation without any errors

      Filter Tex testing

      1. Login as admin
      2. Navigate to Site admin >  Plugins > Filters > Manage Filters
      3. Turn ON the TeX notation filter and apply to Content
      4. Navigate to WWWROOT/filter/tex/texdebug.php
      5. VERIFY there are only 5 tests available.
      6. Edit your profile
      7. In the description type the below text:

        $$ \frac {5}{10} $$ 
        

      8. Click the Update profile button
      9. VERIFY you will see TeX notation without any errors

      Confirm the following returns only function stubs and upgrade notes:

      $ git grep -A0 "\$CFG->slasharguments"

      Ordering question type testing with MacOS

      1. Run the behat testing with tag @qtype_ordering on your MacOS machine.

        mdk behat -r --tags=@qtype_ordering

      2. VERIFY that there is no single failure
      Show
      4.1 to 4.5 testing Open config.php Add $CFG->slasharguments = false; Login as admin. Navigate to Site Administration > Server > Environment Select 4.5 in Moodle version Verify that you will not see slasharguments warning in the Other checks section Select any version lower than 4.5 Verify that you will see slasharguments warning in the Other checks section Main only testing Manual install testing Create a new moodle instance, but don't install it yet. Pull the patch Install the instance Navigate to the Site Admin and search for "slasharguments". Verify the option is not exist. Manual upgrade testing Do not apply the patch. Navigate to the Site Admin and search for "slasharguments". Verify the option is there. Apply the patch. Run the upgrade. Navigate to the Site Admin and search for "slasharguments". Verify the option is gone. Mod Scorm testing After install/upgrade, add the following in the config.php (this will verify that even if there is any forced config for this, it won't be used anymore): $CFG->slasharguments = 0; Navigate to any course page. Add a new Scorm activity. In the form, VERIFY there is no alert "WARNING: slash arguments is disabled on this site and objects may not function as expected!" Specify the name with any name Add the MDL-62640_scorm_sample.zip to Package file Save it VERIFY you can preview the scorm package without any errors. Mod Wiki testing After install/upgrade, add the following in the config.php (this will verify that even if there is any forced config for this, it won't be used anymore): $CFG->slasharguments = 0; Navigate to any course page. Add a new Wiki activity. Specify the wiki name and first page name with any name Set NWiki format in the the Format section Click the Save and display button At the New page form, click the create page button. Select Files at the dropdown Click the Edit wiki files Add the attached image sample.png   Click the Save the changes button Select Edit at the dropdown In the Insert an image dropdown, select the sample.png Click the Save button VERIFY you can see the image without any errors. Filter Algebra testing Note: This is blocked by MDL-83043 . Login as admin Navigate to Site admin >  Plugins > Filters > Manage Filters Turn ON the Algebra notation filter and apply to Content Navigate to WWWROOT/filter/algebra/algebradebug.php VERIFY there are only 5 steps to show algebraic expression Edit your profile In the description type the text "@@sin(z)/(x^2+y^2)@@" (without double quote) Click the Update profile button VERIFY you will see Algebraic Notation without any errors Filter Tex testing Login as admin Navigate to Site admin >  Plugins > Filters > Manage Filters Turn ON the TeX notation filter and apply to Content Navigate to WWWROOT/filter/tex/texdebug.php VERIFY there are only 5 tests available. Edit your profile In the description type the below text: $$ \frac { 5 }{ 10 } $$ Click the Update profile button VERIFY you will see TeX notation without any errors Confirm the following returns only function stubs and upgrade notes: $ git grep -A0 "\$CFG->slasharguments" Ordering question type testing with MacOS Run the behat testing with tag @qtype_ordering on your MacOS machine. mdk behat -r --tags= @qtype_ordering VERIFY that there is no single failure
    • Hide

      Fails against automated checks.

      Checked MDL-83378 using repository: https://github.com/meirzamoodle/moodle.git

      Should these errors be fixed?

      Built on: Mon Mar 17 01:23:53 UTC 2025

      Show
      Fails against automated checks. Checked MDL-83378 using repository: https://github.com/meirzamoodle/moodle.git MOODLE_401_STABLE (0 errors / 0 warnings) [branch: MDL-83378-401 | CI Job ] MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-83378-403 | CI Job ] MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83378-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83378-405 | CI Job ] main (2 errors / 1 warnings) [branch: MDL-83378-main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (2/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/1) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Mon Mar 17 01:23:53 UTC 2025
    • 10
    • Team Dragons 2025 Sprint 1.2, Team Dragons 2025 Sprint 1.3

      Discussed several times before:

      https://moodle.org/mod/forum/discuss.php?d=278916
      MDL-48145

      In 2.9 we proposed enabling slash args by default, and removing the option in 3.0, but that never happened.

        1. Filepicker error.png
          170 kB
          Stevani Andolo
        2. sample.png
          119 kB
          Meirza
        3. screenshot-1.png
          1.93 MB
          Meirza

            meirza.arson@moodle.com Meirza
            meirza.arson@moodle.com Meirza
            Stevani Andolo Stevani Andolo
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 days, 4 hours, 2 minutes
                3d 4h 2m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.