Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-83255

Bug on tab navigation for recommended activities in activitychooser

XMLWordPrintable

    • MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
    • MOODLE_404_STABLE, MOODLE_405_STABLE
    • MDL-83255-MOODLE_403_STABLE
    • MDL-83255-MOODLE_404_STABLE
    • MDL-83255-main
    • Hide
      1. As admin go to website administration -> "Courses" -> "Activity chooser settings"
      2. Change setting "Activity chooser tabs" to "Starred, Recommended, All"
      3. Click on "Recommended activities"
      4. Check three of them
      5. As admin or editing teacher go to a course
      6. Click "Edit mode"
      7. Click "Add activity or resource"
      8. Ensure you do not have the tab "Starred"
      9. Confirm the first tab is "Recommended"
      10. If you have the tab "Starred", unstar all activites you starred
      11. Press tab 4 times
      12. Confirm that the first item in the "Recommended" has been selected
      13. Change setting "Activity chooser tabs" to "Starred, All, Recommended"
      14. Click "Add activity or resource"
      15. Confirm the first tab is "All"
      16. Press tab 4 times
      17. Confirm that the first item in the "All" has been selected
      Show
      As admin go to website administration -> "Courses" -> "Activity chooser settings" Change setting "Activity chooser tabs" to "Starred, Recommended, All" Click on "Recommended activities" Check three of them As admin or editing teacher go to a course Click "Edit mode" Click "Add activity or resource" Ensure you do not have the tab "Starred" Confirm the first tab is "Recommended" If you have the tab "Starred", unstar all activites you starred Press tab 4 times Confirm that the first item in the "Recommended" has been selected Change setting "Activity chooser tabs" to "Starred, All, Recommended" Click "Add activity or resource" Confirm the first tab is "All" Press tab 4 times Confirm that the first item in the "All" has been selected

      When there are recommended activities in /course/recommendations.php and configsetting activitychoosertabmode is set in a way that the recommended tab is shown first when adding a activity, the tabindex is not set correctly so its impossible to navigate to the activities via keyboard.

      When switching and returning to recommended tab, it works.

      Partial Solution:

      I managed to fix a part of the problem in activitychooser.mustache, via setting the tabindex to 0 in the  #recommendedBeginning part, so the tab is reachable.
      Dont know how to do it for the activities, unfortunately.

      If anyone can point me in the right direction, i will try to fix that, too.

      To fix the activities, i had to set aria selected to true, to match the js selectors.
      Also it will only get a tabindex when #faouritesFirst is false.

        1. (1) 9 Passed -- (Main)MDL-83255.png
          (1) 9 Passed -- (Main)MDL-83255.png
          47 kB
        2. (1) 12 Passed -- (Main)MDL-83255.png
          (1) 12 Passed -- (Main)MDL-83255.png
          47 kB
        3. (1) 17 Passed -- (Main)MDL-83255.png
          (1) 17 Passed -- (Main)MDL-83255.png
          85 kB

            toga Tobias Garske
            toga Tobias Garske
            PhMemmel PhMemmel
            Huong Nguyen Huong Nguyen
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 19 minutes
                1h 19m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.