Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-83233

Don't assume the user wants subsections on separate pages

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.5
    • Subsection
    • MOODLE_405_STABLE
    • mdl-83233_main
    • Hide
      1. Create a new Custom sections course with 1 section (besides the General section).
      2. Add two new subsections within Section 1.
      3. Click Collapse all.
      4. Verify both sections are collapsed.
      5. Click to expand the General section.
      6. Verify the General section is expanded.
      7. Click to expand Section 1.
      8. Verify Section 1 is expanded, and the contained subsections are collapsed.
      9. Click Expand all.
      10. Verify all sections and subsections are expanded.
      11. Change the course setting Course format > Course layout to Show one section per page.
      12. Turn Edit mode off (if it isn't already).
      13. Verify Section 1 is shown in summary form (subsections are not displayed), and there is no collapse-state toggler.
      14. Click the section 1 heading, to go to the Section 1 page.
      15. Verify the subsections are displayed in full ("Activities: 0" is not displayed), and there are collapse-state togglers.
      16. Verify the Collapse all toggler is displayed.
      17. Click Collapse all.
      18. Verify both subsections are collapsed.
      19. Click Expand all.
      20. Verify both subsections are expanded.
      Show
      Create a new Custom sections course with 1 section (besides the General section). Add two new subsections within Section 1. Click Collapse all. Verify both sections are collapsed. Click to expand the General section. Verify the General section is expanded. Click to expand Section 1. Verify Section 1 is expanded, and the contained subsections are collapsed. Click Expand all. Verify all sections and subsections are expanded. Change the course setting Course format > Course layout to Show one section per page. Turn Edit mode off (if it isn't already). Verify Section 1 is shown in summary form (subsections are not displayed), and there is no collapse-state toggler. Click the section 1 heading, to go to the Section 1 page. Verify the subsections are displayed in full ("Activities: 0" is not displayed), and there are collapse-state togglers. Verify the Collapse all toggler is displayed. Click Collapse all. Verify both subsections are collapsed. Click Expand all. Verify both subsections are expanded.
    • Hide

      Code verified against automated checks.

      Checked MDL-83233 using repository: https://github.com/james-cnz/moodle

      More information about this report

      Built on: Sun Mar 23 07:39:34 UTC 2025

      Show
      Code verified against automated checks. Checked MDL-83233 using repository: https://github.com/james-cnz/moodle main (0 errors / 0 warnings) [branch: mdl-83233_main | CI Job ] More information about this report Built on: Sun Mar 23 07:39:34 UTC 2025

      Currently, whether subsections are displayed on separate pages is tied to whether regular sections are displayed on separate pages.  I don't think it's reasonable to assume that the user will necessarily want subsections on separate pages if they want regular sections on separate pages.  I think subsections should default to being on the same page, as for regular sections, and if an option is wanted to display them on separate pages, it should be specified explicitly for subsections, either with a separate setting (more flexible), or as an additional option on the existing setting (simpler).

      This patch includes the fix for MDL-81768, which in turn includes the fix for MDL-83262.

            james-cnz James E. Calder
            james-cnz James E. Calder
            Laurent David Laurent David
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.