Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Major
Fix Version/s: 4.1.16, 4.3.10, 4.4.6, 4.5.2
Affects Version/s: Future Dev
Component/s: Database SQL/XMLDB
Labels:

Fixed Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
Drop Oracle Support
Pull from Repository:
https://github.com/meirzamoodle/moodle.git
Pull 4.1 Branch:
~~MDL-83172~~-401-test
Pull 4.1 Diff URL:
https://github.com/meirzamoodle/moodle/compare/f1fbfdf610...MDL-83172-401-test
Pull 4.3 Branch:
~~MDL-83172~~-403-test
Pull 4.3 Diff URL:
https://github.com/meirzamoodle/moodle/compare/59a432a66d...MDL-83172-403-test
Pull 4.4 Branch:
~~MDL-83172~~-404-test
Pull 4.4 Diff URL:
https://github.com/meirzamoodle/moodle/compare/7bf1f87415...MDL-83172-404-test
Pull 4.5 Branch:
~~MDL-83172~~-405-test
Pull 4.5 Diff URL:
https://github.com/meirzamoodle/moodle/compare/71f5b521e9...MDL-83172-405-test
Pull Main Branch:
~~MDL-83172~~-main
Pull Main Diff URL:
https://github.com/meirzamoodle/moodle/compare/f4f166695c...MDL-83172-main
Testing Instructions:
Hide

1. Install Moodle via web.

Install Moodle via the web installer and using the 'Main' branch of this issue.

Choose a language and click the Next button.

Specify the Web address, Moodle directory and Data directory on the Confirm paths page, and then click the Next button.

On the Choose database driver page, Click the type dropdown. VERIFY the options doesn't have 'Oracle (native/oci)'.

2. Change database type to Oracle

Open the `config.php` file in the existing Moodle instance using dbtype other than Oracle (oci).

Change the $CFG->dbtype to oci

Open the Moodle web via browser

VERIFY an error occurred with the message "Error: database driver problem detected".

3. Check environment 5.0 from Moodle 4.5

Install Moodle via the web installer and using the 'MOODLE_405_STABLE' branch of this issue and Choose oracle/OCI as the database driver.

Ensure to install filp/whoops library.

Navigate to Site Admins > Server > Environment

At the Moodle version dropdown, select the "5.0 upwards"

VERIFY the server check table has an error badge label in the database row.

4. Execute the following

git --no-pager grep -i -E '\b(oci|oracle)\b' -- ':!*.js' ':!*.map' ':!*.txt' ':!*.json' ':!*.md' ':!*.pem' ':!vendor/*' ':!node_modules/*' ':!lib/*/*'

VERIFY it only returns:

The upgrade note regarding the removal of Oracle.

The `environment.xml` file with a version 4.5 or lower.

A comment indicating the need to optimize the current query, similar to this:
// TODO: Optimise the query, as Oracle-specific constraints no longer apply.

The `auth_plugin_db` remains unchanged, as the Oracle reference relate to the external library AdoDB
Show
1. Install Moodle via web. Install Moodle via the web installer and using the 'Main' branch of this issue. Choose a language and click the Next button. Specify the Web address, Moodle directory and Data directory on the Confirm paths page, and then click the Next button. On the Choose database driver page, Click the type dropdown. VERIFY the options doesn't have 'Oracle (native/oci)'. 2. Change database type to Oracle Open the `config.php` file in the existing Moodle instance using dbtype other than Oracle (oci). Change the $CFG->dbtype to oci Open the Moodle web via browser VERIFY an error occurred with the message "Error: database driver problem detected". 3. Check environment 5.0 from Moodle 4.5 Install Moodle via the web installer and using the 'MOODLE_405_STABLE' branch of this issue and Choose oracle/OCI as the database driver. Ensure to install filp/whoops library. Navigate to Site Admins > Server > Environment At the Moodle version dropdown, select the "5.0 upwards" VERIFY the server check table has an error badge label in the database row. 4. Execute the following git --no-pager grep -i -E '\b(oci|oracle)\b' -- ':!*.js' ':!*.map' ':!*.txt' ':!*.json' ':!*.md' ':!*.pem' ':!vendor/*' ':!node_modules/*' ':!lib/*/*' VERIFY it only returns: The upgrade note regarding the removal of Oracle. The `environment.xml` file with a version 4.5 or lower. A comment indicating the need to optimize the current query, similar to this: // TODO: Optimise the query, as Oracle-specific constraints no longer apply. The `auth_plugin_db` remains unchanged, as the Oracle reference relate to the external library AdoDB
Pre-check results:
Hide

Fails against automated checks.

Checked ~~MDL-83172~~ using repository: https://github.com/meirzamoodle/moodle.git

MOODLE_401_STABLE (3 errors / 0 warnings) [branch: MDL-83172-401 | CI Job]

overview (0/0), phplint (0/0), phpcs (3/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_403_STABLE (3 errors / 0 warnings) [branch: MDL-83172-403 | CI Job]

overview (0/0), phplint (0/0), phpcs (3/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_404_STABLE (3 errors / 0 warnings) [branch: MDL-83172-404 | CI Job]

overview (0/0), phplint (0/0), phpcs (3/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_405_STABLE (3 errors / 0 warnings) [branch: MDL-83172-405 | CI Job]

overview (0/0), phplint (0/0), phpcs (3/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

main (6 errors / 10 warnings) [branch: MDL-83172-main | CI Job]

overview (0/0), phplint (0/0), phpcs (6/10), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Mon 09 Dec 2024 09:00:48 AM UTC
Show
Fails against automated checks. Checked MDL-83172 using repository: https://github.com/meirzamoodle/moodle.git MOODLE_401_STABLE (3 errors / 0 warnings) [branch: MDL-83172-401 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (3/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_403_STABLE (3 errors / 0 warnings) [branch: MDL-83172-403 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (3/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_404_STABLE (3 errors / 0 warnings) [branch: MDL-83172-404 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (3/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_405_STABLE (3 errors / 0 warnings) [branch: MDL-83172-405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (3/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , main (6 errors / 10 warnings) [branch: MDL-83172-main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (6/10) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Mon 09 Dec 2024 09:00:48 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83172~~-401

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17654/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60150/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60151/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83172~~-403

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17655/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60152/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60153/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83172~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17656/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60154/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60155/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83172~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17657/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60156/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60157/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83172~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17658/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60158/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60159/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60160/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60161/ App tests (stable app version)

Built on: Mon Dec 9 08:25:25 AM UTC 2024
Show
Launching automatic jobs for branch MDL-83172 -401 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17654/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60150/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60151/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83172 -403 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17655/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60152/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60153/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83172 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17656/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60154/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60155/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83172 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17657/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60156/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60157/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83172 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17658/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60158/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60159/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60160/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60161/ App tests (stable app version) Built on: Mon Dec 9 08:25:25 AM UTC 2024

Story Points:
6
Sprint:
Team Hedgehog 2024 Sprint 4.1, Team Hedgehog 2024 Sprint 4.2, Team Hedgehog 2024 Sprint 4.3, Team Hedgehog 2025 Sprint 1.0

We're removing support for the Oracle database support from LMS.

This ticket is to cover the removing the code and tests from the LMS codebase.

This can commence as soon as we finish the onsync period for LMS 4.5

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

83172_changedbtype.png
15/Jan/25 5:58 PM
30 kB
Jun Pataleta
83172_installdboptions_cli.png
15/Jan/25 6:01 PM
24 kB
Jun Pataleta
83172_installodboptions.png
15/Jan/25 5:58 PM
85 kB
Jun Pataleta
83172_stable_envcheck.png
15/Jan/25 5:58 PM
131 kB
Jun Pataleta
image-2025-01-14-16-03-53-607.png
14/Jan/25 5:03 PM
83 kB
Meirza

blocks

MDL-80173 Evaluate remaining support for Oracle in Report builder

Closed

has been marked as being related by

MDL-83470 Decide Moodle 5.0 requirements and push them to environment.xml (due date: 15 Nov 2024)

Closed

has to be done before

MDLSITE-7898 Remove Oracle from Moodle 5.0 requirements

Closed

Assignee:: Meirza

Reporter:: Matt Porritt

Peer reviewer:: David Woloszyn

Integrator:: Jun Pataleta

Tester:: Jun Pataleta

Participants:: CiBoT, David Woloszyn, Jun Pataleta, Matt Porritt, Meirza, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 10 Start watching this issue

Created:: 17/Sep/24 9:54 AM

Updated:: 11/Apr/25 5:42 PM

Resolved:: 17/Jan/25 1:11 AM

Estimated:

Remaining:

Logged:

1w 1d 35m

Details

1. Install Moodle via web.

2. Change database type to Oracle

3. Check environment 5.0 from Moodle 4.5

4. Execute the following

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify