We've been having lots of problems doing any fresh install of MWP 4.42 onwards and MoodleLMS 4.36 onwards whilst including our own local plugins (referred to as [local_plugin] and [course/format/custom_plugin].

Attempting to run the install_database.php fails with error "resolve dependancies for accipioone_discover". This is despite dependencies being met on-disk. This only appears to affect builds using MWP and MoodleLMS after version 4.4.1 and 4.3.5 (so 4.4.2 and 4.3.6 onwards, I think)

{{root@ip-10-100-21-132:/var/www/html# sudo -u www-data php admin/cli/install_database.php --lang=en --adminuser=[removed] --adminpass=[removed] --adminemail=[removed] --agree-license --fullname="[sitename]" --shortname="[shortname]" }}

Dependencies check failed for [local_plugin]

You must solve all the plugin requirements before proceeding to install this Moodle version!

 
Our developers believe they have identified the issue is in Moodle core.
 
When Moodle validates plugins dependencies, it gets plugins list based on plugin type.
For [course/format/custom_plugin] it checks additional configuration to sort formats.

 
The left screenshot shows the code of the new core_plugin_manager which is getting the plugins to be installed (https://github.com/moodle/moodle/blob/1938c438ea1385eb2f62be4df5581e3458588e66/course/lib.php#L2894) . The right screenshot shows what was there before.

 
As it checks dependencies before installation, we have not added the $CFG->version and 'config_plugins' table yet, so it returns empty array. This looks to be why we have an issue with course format dependency validation.
 

Please can this be reviewed?
 
Thanks,
Tim