Loading...

XML

Word

Printable

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/marinaglancy/moodle
Pull Main Branch:
~~MDL-83052~~
Pull Main Diff URL:
https://github.com/marinaglancy/moodle/compare/moodle:main...marinaglancy:moodle:MDL-83052
Testing Instructions:
Hide

Create a new course custom field of type 'Number' and call it "Price"

Set "Display as zero" to "Free"

For one course set the value of this field to 0

For another course do not set the value

For the third course set it to 10 (or any other positive number)

Open http://yoursite/course/ page and make sure that the first course is displaeyd as "Free", the second does not have the price field at all and the third one displays "10"
Show
Create a new course custom field of type 'Number' and call it "Price" Set "Display as zero" to "Free" For one course set the value of this field to 0 For another course do not set the value For the third course set it to 10 (or any other positive number) Open http://yoursite/course/ page and make sure that the first course is displaeyd as "Free", the second does not have the price field at all and the third one displays "10"

There are a couple of things I noticed when updating my moodle lms instance today

Where I had a number custom field that was not set it displays as "0" . This could be a problem with the fields such as price, if the price is set as "0" they should be displayed as "Free", if the price is not set, the field should not be displayed at all.
I got a PHP warning about passing null as the third argument of str_replace
Value such as 0.000001 (which can be a glitch in how db stores floats) is displayed as "0.00", it should not be displayed at all (when the "Display as zero" set to "" and the "Decimal places" is set to "2")

has a non-specific relationship to

MDL-80858 Add numeric field type for course custom fields

Participants:: CiBoT, Jun Pataleta, Marina Glancy, Paul Holden, Ron Carl Alfon Yu

Estimated:

Remaining:

Logged:

2h 39m