Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.5, 5.0.1
Affects Version/s: 4.4, 4.5, 5.0
Component/s: Blocks
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/catalyst/moodle
Pull 4.5 Branch:
~~MDL-83044~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...catalyst:moodle:MDL-83044-405
Pull 5.0 Branch:
~~MDL-83044~~-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...catalyst:moodle:MDL-83044-500
Pull Main Branch:
~~MDL-83044~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...catalyst:moodle:MDL-83044
Testing Instructions:
Hide

Testing:

Setup a Moodle site

Install the tool_blocksmanager plugin

Open the site root directory in your terminal

git clone -b MOODLE_404_STABLE git@github.com:catalyst/moodle_tool_blocksmanager.git admin/tool/blocksmanager

Navigate to /admin/tool/blocksmanager/region.php

Click Add new locked region

Set region to side-pre

Select all categories (e.g. Category 1)

Set Allow to add? to No

Save changes

Navigate to a course in one of the selected categories

Log in as a teacher (setting role to teacher won't work)

Attempt to add a block (e.g. Text block)

Verify you see a red notice banner with the message 'The region is locked. Changes will not be saved.'
Show
Testing: Setup a Moodle site Install the tool_blocksmanager plugin Open the site root directory in your terminal git clone -b MOODLE_404_STABLE git@github.com:catalyst/moodle_tool_blocksmanager.git admin/tool/blocksmanager Navigate to /admin/tool/blocksmanager/region.php Click Add new locked region Set region to side-pre Select all categories (e.g. Category 1 ) Set Allow to add? to No Save changes Navigate to a course in one of the selected categories Log in as a teacher (setting role to teacher won't work) Attempt to add a block (e.g. Text block) Verify you see a red notice banner with the message 'The region is locked. Changes will not be saved.'
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83044~~ using repository: https://github.com/catalyst/moodle

MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-83044-403 | CI Job]

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83044-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83044-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83044 | CI Job]

_{More information about this report}

Built on: Mon Mar 17 00:29:46 UTC 2025
Show
Code verified against automated checks. Checked MDL-83044 using repository: https://github.com/catalyst/moodle MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-83044-403 | CI Job ] MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83044-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83044-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83044 | CI Job ] More information about this report Built on: Mon Mar 17 00:29:46 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83044~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19456/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66567/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66568/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66569/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-83044~~-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19457/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66570/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66571/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66572/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-83044~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19458/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66573/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66574/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66575/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66576/ App tests (stable app version) / complete)

Built on: Tue May 27 00:10:10 UTC 2025
Show
Launching automatic jobs for branch MDL-83044 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19456/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66567/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66568/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66569/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-83044 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19457/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66570/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66571/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66572/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-83044 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19458/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66573/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66574/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66575/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66576/ App tests (stable app version) / complete) Built on: Tue May 27 00:10:10 UTC 2025

The call to add_block_at_end_of_default_region can return null, but if it does, an exception is thrown (block_not_on_page_exception) when find_instance is called.

This can happen if a plugin overrides add_block_at_end_of_default_region and intentionally returns null in order to prevent a user adding a block:

https://moodle.org/plugins/tool_blocksmanager

https://github.com/moodle/moodle/blob/main/blocks/edit_form.php#L434-L452

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

issue_record.webm
5.56 MB
16/Sep/24 11:01 PM
issue.png
112 kB
16/Sep/24 11:01 PM
MDL-83044.png
80 kB
29/May/25 2:26 PM
Screencast from 29-10-24.webm
5.27 MB
29/Oct/24 10:27 AM
Screenshot from 2024-09-08 21-27-00.png
139 kB
08/Sep/24 9:40 PM

has a non-specific relationship to

MDL-83098 Add type declarations to class block_manager

Closed

has been marked as being related by

MDL-74465 Display block configuration form in a popup

Closed

Assignee:: Alexander Van der Bellen

Reporter:: Alexander Van der Bellen

Peer reviewer:: Dmitrii Metelkin

Integrator:: David Woloszyn

Tester:: Ron Carl Alfon Yu

Participants:: Alexander Van der Bellen, CiBoT, David Woloszyn, Dmitrii Metelkin, Huong Nguyen, Ron Carl Alfon Yu, Safat Shahin

Votes:: 1 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 08/Sep/24 9:38 PM

Updated:: 04/Jun/25 8:31 AM

Resolved:: 30/May/25 5:07 PM

Estimated:

Remaining:

Logged:

3w 3d 7h 22m

Details

Testing:

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify