Loading...

XML

Word

Printable

Type: Task
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.5
Component/s: Lesson
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
5.0 deprecations
Pull from Repository:
https://github.com/andrewgos/moodle.git
Pull Main Branch:
~~MDL-82937~~-main
Pull Main Diff URL:
https://github.com/andrewgos/moodle/compare/139a0ad5f0...MDL-82937-main?w=1
Testing Instructions:
Hide

Test #1

Execute the following:

git grep -C3 "tabs.php[^_]"

Confirm that there are no usages of /mod/lesson/tabs.php

Confirm upgrade notes regarding removal.
Show
Test #1 Execute the following: git grep -C3 "tabs.php[^_]" Confirm that there are no usages of /mod/lesson/tabs.php Confirm upgrade notes regarding removal.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-82937~~ using repository: https://github.com/andrewgos/moodle.git

main (0 errors / 0 warnings) [branch: MDL-82937-main | CI Job]

_{More information about this report}

Built on: Tue Feb 11 09:41:38 AM UTC 2025
Show
Code verified against automated checks. Checked MDL-82937 using repository: https://github.com/andrewgos/moodle.git main (0 errors / 0 warnings) [branch: MDL-82937-main | CI Job ] More information about this report Built on: Tue Feb 11 09:41:38 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-82937~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18246/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62352/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62353/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62354/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62355/ App tests (stable app version) --> random failure, please ignore.

Built on: Wed Feb 12 12:30:54 PM UTC 2025
Show
Launching automatic jobs for branch MDL-82937 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18246/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62352/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62353/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62354/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62355/ App tests (stable app version) --> random failure, please ignore. Built on: Wed Feb 12 12:30:54 PM UTC 2025

There are no more uses or references to mod/lesson/tabs.php and there haven't been since the module navigation changes in ~~MDL-71914~~.

We should remove it, and any indirect leftover references to it still hanging around from the previously mentioned change. Note this isn't intended as a public API, so straight deletion seems appropriate.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 3 Passed -- (Main)MDL-82937.png
273 kB
10/Mar/25 9:03 AM

Discovered while testing

MDL-82301 Remove legacy tabs.php file from Feedback module

Closed

Assignee:: Andrew Gosali

Reporter:: Sara Arjona (@sarjona)

Peer reviewer:: Sara Arjona (@sarjona)

Integrator:: Mihail Geshoski

Tester:: Kim Jared Lucas

Participants:: Andrew Gosali, Andrew Lyons, CiBoT, Jun Pataleta, Kim Jared Lucas, Mihail Geshoski, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 28/Aug/24 10:41 PM

Updated:: 11/Apr/25 6:02 PM

Resolved:: 11/Mar/25 8:30 PM

Estimated:

Not Specified

Remaining:

Logged:

4h 29m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify