Problem

With reference to an activity where attempts have been graded: 

If the rule for an associated competency is added or changed, there is no systematic way to update competencies for activities completed in the past.

In an activity settings there is the ability to 'Unlock completion settings' in the activity completion section.

This will recalculate the completion, however, if a competency has a completed grade, the rules will not be applied.

When the completions for an activity are recalculated, there is condition that only triggers the rules to be applied (and update the parent) if the child competency CHANGES to 'Achieved' (and thus proficiency is true) and all children are completed.

Steps to reproduce:

1. Create an activity with completion conditions. Leave competency rule as 'None'
2. Log in as a student and complete the activity.
3. Log in as a teacher and grade the activity.
4. Change competency rule to 'Mark as complete' and set when 'All children are complete'
5. Click 'Unlock completion settings' in the activity completion section of the activity settings.
6. Save

Outcome: The completions will be recalculated, however the course competency will not be updated for any already graded attempts.