Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 5.0
Component/s: Libraries
Labels:

Affected Branches:
MOODLE_500_STABLE
Fixed Branches:
MOODLE_500_STABLE
Pull from Repository:
https://github.com/ziegenberg/moodle
Pull Main Branch:
~~MDL-82825~~_remove-php-enum-library
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...ziegenberg:MDL-82825_remove-php-enum-library
Testing Instructions:
Hide

Confirm all automated tasks are happy (Behat and Unit test)

Execute the following:

git grep -C2 "php-enum"

Confirm it returns only upgrade notes regarding the removal, notes in upgrade.txt and a comment in lib/phpspreadsheet/readme_moodle.txt.
Show
Confirm all automated tasks are happy (Behat and Unit test) Execute the following: git grep -C2 "php-enum" Confirm it returns only upgrade notes regarding the removal, notes in upgrade.txt and a comment in lib/phpspreadsheet/readme_moodle.txt.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-82825~~ using repository: https://github.com/ziegenberg/moodle

main (0 errors / 0 warnings) [branch: MDL-82825_remove-php-enum-library | CI Job]

_{More information about this report}

Built on: Fri Feb 21 09:17:42 AM UTC 2025
Show
Code verified against automated checks. Checked MDL-82825 using repository: https://github.com/ziegenberg/moodle main (0 errors / 0 warnings) [branch: MDL-82825_remove-php-enum-library | CI Job ] More information about this report Built on: Fri Feb 21 09:17:42 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-82825~~_remove-php-enum-library

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17961/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61276/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61277/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61278/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61279/ App tests (stable app version)

Built on: Fri Jan 17 02:25:13 AM UTC 2025
Show
Launching automatic jobs for branch MDL-82825 _remove-php-enum-library https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17961/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61276/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61277/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61278/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61279/ App tests (stable app version) Built on: Fri Jan 17 02:25:13 AM UTC 2025

It was a dependency of zipstream, but is no longer required as this functionality has been replaced by native PHP functionality.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-82825_test.png
26/Feb/25 8:03 PM
126 kB
Sara Arjona (@sarjona)

Discovered while testing

MDL-82824 Add unit test to check Moodle autoloader from Composer

Closed

has been marked as being related by

MDL-83400 Review third party libraries for new versions (5.0 release)

Closed

MDL-84223 PR only: MDL-82825 - Remove php-enum library

Closed

will help resolve

MDL-77101 Using soft reserved words (numeric, enum) could break in the future

Open

Assignee:: Daniel Ziegenberg

Reporter:: Andrew Lyons

Peer reviewer:: David Woloszyn

Integrator:: Sara Arjona (@sarjona)

Tester:: Sara Arjona (@sarjona)

Participants:: Andrew Lyons, CiBoT, Daniel Ziegenberg, David Woloszyn, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 20/Aug/24 12:24 AM

Updated:: 11/Apr/25 6:15 PM

Resolved:: 28/Feb/25 12:56 AM

Estimated:

Remaining:

Logged:

1h 31m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify