Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82788

Autoscroll has an issue with form validation errors when using a required editor (TinyMCE + Atto)

XMLWordPrintable

    • MOODLE_405_STABLE
    • MOODLE_404_STABLE, MOODLE_405_STABLE
    • MDL-82788-404
    • MDL-82788-405
    • MDL-82788-main
    • Hide

      1. Testing MDL-81066

      1. Log in as admin.
      2. Go to the Site administration / Courses / Add new course page.
      3. Use the Tab key to continue through the Course full name and Course short name fields without entering any data in them
        • EXPECTED: Error messages should not appear next to the fields.
      4. Click Save and display at the bottom of the form.
        • EXPECTED: The screen scrolls smoothly up to show the Course full name field, which is focused.
        • EXPECTED: Error messages appear next to both fields ('Missing full name', 'Missing short name').
      5. Click Save and display again without fixing the errors.
        • EXPECTED: The screen scrolls up and focuses the first error field again.
      6. Use the Tab key to navigate through both fields.
        • EXPECTED The error messages should not be included in the tab order; the Tab key from a field takes you to the next control which can be activated (the help icon for the next field).
      7. Fix the errors (set both fields to values) and click Save and display.
        • (Existing behaviour) Form should save OK and go back to course page.
      8. Go back into the Settings tab and delete the value from the full name field.
      9. Press the Tab key
        • EXPECTED The 'Missing full name' message should appear immediately, and the field should remain focused.
      10. Press the Tab key again.
        • EXPECTED: User can tab out of field now that the message has appeared
      11. Click Cancel at bottom of form.
        • (Existing behaviour) Form should cancel OK and go back to course page (full name is not changed).

      2. Testing on Modal

      1. Set up TinyMCE as your default editor on your editor preferences.
      2. Go to site admin > reports > report builder > custom reports
      3. Add a new report, just pick 'course' source or whatever
      4. Click the 'Schedules' tab and create a new schedule (this will be a modal)
      5. Enter the two required text inputs (name, subject), but leave the editor input empty
      6. Make sure you're scrolled to the top of the modal view
      7. Click to save
      8. VERIFY you're scrolled to the editor element that has the "- You must supply a value here."
      9. Please repeat steps 2 - 8 with the Atto editor

      3. Testing on essay question

      1. Set up TinyMCE as your default editor on your editor preferences.
      2. Create a course
      3. Create a quiz
      4. Go to add question and add a new question Essay type
      5. Go down and save the question
      6. VERIFY the page will go up to the Question Name
      7. Enter a Name to that question and go down to save the question
      8. VERIFY you're scrolled to the editor element that has the "- You must supply a value here."
      9. Please repeat steps 2 - 8 with the Atto editor
      Show
      1. Testing MDL-81066 Log in as admin. Go to the Site administration / Courses / Add new course page. Use the Tab key to continue through the Course full name and Course short name fields without entering any data in them EXPECTED: Error messages should not appear next to the fields. Click Save and display at the bottom of the form. EXPECTED: The screen scrolls smoothly up to show the Course full name field, which is focused. EXPECTED: Error messages appear next to both fields ('Missing full name', 'Missing short name'). Click Save and display again without fixing the errors. EXPECTED: The screen scrolls up and focuses the first error field again. Use the Tab key to navigate through both fields. EXPECTED The error messages should not be included in the tab order; the Tab key from a field takes you to the next control which can be activated (the help icon for the next field). Fix the errors (set both fields to values) and click Save and display . (Existing behaviour) Form should save OK and go back to course page. Go back into the Settings tab and delete the value from the full name field. Press the Tab key EXPECTED The 'Missing full name' message should appear immediately, and the field should remain focused. Press the Tab key again. EXPECTED: User can tab out of field now that the message has appeared Click Cancel at bottom of form. (Existing behaviour) Form should cancel OK and go back to course page (full name is not changed). 2. Testing on Modal Set up TinyMCE as your default editor on your editor preferences. Go to site admin > reports > report builder > custom reports Add a new report, just pick 'course' source or whatever Click the 'Schedules' tab and create a new schedule (this will be a modal) Enter the two required text inputs (name, subject), but leave the editor input empty Make sure you're scrolled to the top of the modal view Click to save VERIFY you're scrolled to the editor element that has the "- You must supply a value here." Please repeat steps 2 - 8 with the Atto editor 3. Testing on essay question Set up TinyMCE as your default editor on your editor preferences. Create a course Create a quiz Go to add question and add a new question Essay type Go down and save the question VERIFY the page will go up to the Question Name Enter a Name to that question and go down to save the question VERIFY you're scrolled to the editor element that has the "- You must supply a value here." Please repeat steps 2 - 8 with the Atto editor
    • Hide

      Code verified against automated checks.

      Checked MDL-82788 using repository: https://github.com/meirzamoodle/moodle.git

      More information about this report

      Built on: Wed 27 Nov 2024 01:39:30 PM UTC

      Show
      Code verified against automated checks. Checked MDL-82788 using repository: https://github.com/meirzamoodle/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-82788-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-82788-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-82788-main | CI Job ] More information about this report Built on: Wed 27 Nov 2024 01:39:30 PM UTC
    • Hide

      Launching automatic jobs for branch MDL-82788-404

      Launching automatic jobs for branch MDL-82788-405

      Launching automatic jobs for branch MDL-82788-main

      Built on: Wed Nov 27 02:25:22 PM UTC 2024

      Show
      Launching automatic jobs for branch MDL-82788 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17555/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59769/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59770/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-82788 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17556/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59771/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59772/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-82788 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17557/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59773/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59774/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59775/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59776/ App tests (stable app version) Built on: Wed Nov 27 02:25:22 PM UTC 2024
    • 2
    • Team Hedgehog 2024 Sprint 4.2, Team Hedgehog 2024 Sprint 4.3, Team Hedgehog 2025 Sprint 1.0

      Originally reported on MDL-82785, but that reported two things, so it's been split out into this issue.

      This seems to be a regression in 4.4, since it's working fine in 4.3.

      To replicate (at least one place, though there are likely others):

      1. Go to site admin > reports > report builder > custom reports
      2. Add a new report, just pick 'course' source or whatever
      3. Click the 'Schedules' tab and create a new schedule (this will be a modal)
      4. Enter the two required text inputs (name, subject), but leave the editor input empty
      5. Make sure you're scrolled to the top of the modal view
      6. Click to save
      7. Notice you're not scrolled to the element that has the "This field is required" error. On 4.3, this DOES occur.

        1. MDL-82788.png
          MDL-82788.png
          587 kB
        2. MDL-82788-essay.png
          MDL-82788-essay.png
          617 kB
        3. MDL-82788-modal.png
          MDL-82788-modal.png
          245 kB

            meirza.arson@moodle.com Meirza
            jaked Jake Dallimore
            Raquel Ortega Raquel Ortega
            Safat Shahin Safat Shahin
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 3 hours, 33 minutes
                2d 3h 33m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.