Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82706

Bring back the removed filter.php files

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.5
    • 4.5
    • Filters
    • MOODLE_405_STABLE
    • MOODLE_405_STABLE
    • MDL-82706-main-2
    • Hide
      1. Download filter_require_test.php to your moodle instance's root folder.
      2. Ensure that debugging is turned on. (if using mdk, run "mdk run mindev")
      3. Open "filter_require_test.php" on a browser
      4. Confirm that you see the following debugging message for each filter plugin that is being required:

        This file is no longer required in Moodle 4.5+. Please do not include/require it.

      5. Confirm that you also see the following debugging message:

        Class 'filter_[plugin name]' has been renamed for the autoloader and is now deprecated. Please use 'filter_[plugin name]\text_filter' instead.
        

      Show
      Download filter_require_test.php to your moodle instance's root folder. Ensure that debugging is turned on. (if using mdk, run " mdk run mindev ") Open " filter_require_test.php " on a browser Confirm that you see the following debugging message for each filter plugin that is being required: This file is no longer required in Moodle 4.5+. Please do not include/require it. Confirm that you also see the following debugging message: Class 'filter_[plugin name]' has been renamed for the autoloader and is now deprecated. Please use 'filter_[plugin name]\text_filter' instead.

      MDL-82427 moved the filter.php files of the filter plugins to the classes folder and renamed them text_filter.php, essentially deleting them. This can lead to fatal errors when they are required/included elsewhere.

      Although filter.php files are plugin-specific and should not normally be required by plugins (unless the plugins somehow declare dependency on specific filter plugins), as doing so would break component communication principles, we should consider creating the filter.php files back to prevent errors due to such cases.

        1. filter_require_test.php
          0.8 kB
          Jun Pataleta
        2. (1) 4 Passed -- (Main)MDL-82706.png
          86 kB
          Kim Jared Lucas
        3. (1) 5 Passed -- (Main)MDL-82706.png
          88 kB
          Kim Jared Lucas

            jpataleta Jun Pataleta
            jpataleta Jun Pataleta
            Tim Hunt Tim Hunt
            Huong Nguyen Huong Nguyen
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 38 minutes
                1h 38m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.