-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
4.3.5, 4.4.1
-
MOODLE_403_STABLE, MOODLE_404_STABLE
-
MOODLE_404_STABLE
-
MDL-82484_fix_quickform_find_value
-
Fails against automated checks. 
Checked MDL-82484 using repository: https://github.com/chen-gloria/moodle.git
Testing instructions are missing.- MOODLE_404_STABLE [branch: MOODLE_404_STABLE | CI Job]
- Error: The MOODLE_404_STABLE branch at https://github.com/chen-gloria/moodle.git is very old (>60 days ago). Please rebase against current MOODLE_404_STABLE.
- main [branch: MDL-82484_fix_quickform_find_value | CI Job]
- Error: The MDL-82484_fix_quickform_find_value branch at https://github.com/chen-gloria/moodle.git is very old (>60 days ago). Please rebase against current main.
Built on: Wed Mar 5 20:35:45 UTC 2025
Fails against automated checks. Checked MDL-82484 using repository: https://github.com/chen-gloria/moodle.git Testing instructions are missing. MOODLE_404_STABLE [branch: MOODLE_404_STABLE | CI Job ] Error: The MOODLE_404_STABLE branch at https://github.com/chen-gloria/moodle.git is very old (>60 days ago). Please rebase against current MOODLE_404_STABLE. main [branch: MDL-82484_fix_quickform_find_value | CI Job ] Error: The MDL-82484 _fix_quickform_find_value branch at https://github.com/chen-gloria/moodle.git is very old (>60 days ago). Please rebase against current main. Should these errors be fixed? Built on: Wed Mar 5 20:35:45 UTC 2025
Fatal error: Declaration of HTML_QuickForm_file::_findValue() must be compatible with HTML_QuickForm_element::_findValue(&$values)
I tried to add `$mform->addElement('file'...)` to my form, it triggered this error. Then I inspected the code and found out that the `&$values` is missing from the child function `_findValue`
