Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82483

Correct the value of the maximum tag length constant

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.3.8, 4.4.4
    • 4.3.6, 4.4.2
    • Tags
    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MDL-82483-403
    • MDL-82483-404
    • Hide
      1. Log in as admin
      2. Navigate to Appearance > Manage tags in site administration
      3. Press Default collection
      4. Press Add standard tags
      5. Enter "horse" and press Continue in the modal
      6. From actions, press Edit to edit the "horse" tag
      7. In "Tag name" enter the following 255 character string: 

        Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin in felis pellentesque, ultrices sapien sit amet, porttitor lacus. Vivamus convallis sodales enim, sed sodales urna elementum ut. Donec venenatis malesuada dui ac laoreet. Praesent blandit dui.

      8. Press Update
      9. Confirm the entire tag name was updated
      Show
      Log in as admin Navigate to Appearance > Manage tags in site administration Press Default collection Press Add standard tags Enter "horse" and press Continue in the modal From actions, press Edit to edit the "horse" tag In "Tag name" enter the following 255 character string: Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin in felis pellentesque, ultrices sapien sit amet, porttitor lacus. Vivamus convallis sodales enim, sed sodales urna elementum ut. Donec venenatis malesuada dui ac laoreet. Praesent blandit dui. Press Update Confirm the entire tag name was updated

      See the value defined here: https://github.com/moodle/moodle/blob/fd487cd3f2001453c22418cce396c9c8e5d4a2a5/lib/moodlelib.php#L393-L401

      define('TAG_MAX_LENGTH', 50);

      The commit that added the TODO to fix this is almost old enough to drink, let's put it out of its misery

      For context, the maximum length as defined in DB schema is 255: https://github.com/moodle/moodle/blob/fd487cd3f2001453c22418cce396c9c8e5d4a2a5/lib/db/install.xml#L2299-L2300

        1. MDL-82483.png
          156 kB
          Ron Carl Alfon Yu

            pholden Paul Holden
            pholden Paul Holden
            Daniel Ziegenberg Daniel Ziegenberg
            Huong Nguyen Huong Nguyen
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 25 minutes
                25m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.