Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82344

LTI Select content button has become required

XMLWordPrintable

    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MDL-82344-403
    • MDL-82344-404
    • MDL-82344-main
    • Hide

      This test requires a test with a tool supporting content selection. We'll just use Moodle's LTI tool.

      Prerequisites

      1. Create two sites: one called "platform" and the other called "tool". The patch here only need exist on the "platform" site
      2. Disable debugging on the platform site to sidestep the debug-only issue, MDL-80674
      3. Set up Moodle to Moodle LTI per the docs here: https://docs.moodle.org/404/en/LTI_Moodle_to_Moodle
      4. Make sure you've published at least one activity or course in the tool site

      Testing

      1. Log in to the platform site as the admin
      2. Go to a course
      3. Go to course tools
      4. Make sure "show in activity chooser" is enabled for the Moodle tool you created earlier
      5. Go to the course home
      6. Turn editing on
      7. Click to add an activity or resource, selecting the "tool" site tool (whatever you called it)
      8. Verify the following when the form loads:
        • The "select content" button is grey, not blue
        • There is no "required" indicator for the "select content" button/group
      9. Enter a name for the activity and save and return to course
      10. Launch the link you just created
      11. Verify you see an error about a required custom claim field 'id' (this just confirms that the tool is launching to the default tool URL. Moodle tool doesn't support this kind of launch, so the error is normal)
      12. Edit the settings for the activity you just launched
      13. Verify you do not see " Content selected" next to the button on page load
      14. Click to add an activity or resource, selecting the "tool" site tool (whatever you called it)
      15. This time, click "select content"
      16. Proceed through account linking, if not already done
      17. When presented with the content list, select the activity or course that you published in the tool site
      18. Select "Add content"
      19. Verify:
        • You see " Content selected" next to the button
        • The name of the activity has been updated to the name of the activity on the tool site
      20. Save and return to the course
      21. # Launch the link you just created
      22. Verify you are taken to either the activity or the course you published, without error.
      23. Edit the activity settings for the link you just launched
      24. Verify you see " Content selected" next to the button on page load
      Show
      This test requires a test with a tool supporting content selection. We'll just use Moodle's LTI tool. Prerequisites Create two sites: one called "platform" and the other called "tool". The patch here only need exist on the "platform" site Disable debugging on the platform site to sidestep the debug-only issue, MDL-80674 Set up Moodle to Moodle LTI per the docs here: https://docs.moodle.org/404/en/LTI_Moodle_to_Moodle Make sure you've published at least one activity or course in the tool site Testing Log in to the platform site as the admin Go to a course Go to course tools Make sure "show in activity chooser" is enabled for the Moodle tool you created earlier Go to the course home Turn editing on Click to add an activity or resource, selecting the "tool" site tool (whatever you called it) Verify the following when the form loads: The "select content" button is grey, not blue There is no "required" indicator for the "select content" button/group Enter a name for the activity and save and return to course Launch the link you just created Verify you see an error about a required custom claim field 'id' (this just confirms that the tool is launching to the default tool URL. Moodle tool doesn't support this kind of launch, so the error is normal) Edit the settings for the activity you just launched Verify you do not see " Content selected" next to the button on page load Click to add an activity or resource, selecting the "tool" site tool (whatever you called it) This time, click "select content" Proceed through account linking, if not already done When presented with the content list, select the activity or course that you published in the tool site Select "Add content" Verify: You see " Content selected" next to the button The name of the activity has been updated to the name of the activity on the tool site Save and return to the course # Launch the link you just created Verify you are taken to either the activity or the course you published, without error. Edit the activity settings for the link you just launched Verify you see " Content selected" next to the button on page load
    • 1
    • Team Alpha - Planning I3-2024

      In MDL-78916 (>=4.3), the Select content button in LTI was changed to be required. It was even called out in the acceptance criteria - but why?

      Some tools (like Panopto, and I think Zoom) use not deep linking to indicate that you want the course wide content (like a listing of all content).

      And in the External tool config, it is called "Supports Deep Linking", and will be "made available":

      I did some reading of the LTI spec, and couldn't find any reason that it should be required, even if the remote end supports it.

      See this discussion of the same problem, reported by Pearson: https://moodle.org/mod/forum/discuss.php?d=460121

            jaked Jake Dallimore
            emerrill Eric Merrill
            Mihail Geshoski Mihail Geshoski
            Glyn (Mathew) May Glyn (Mathew) May
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            14 Vote for this issue
            Watchers:
            19 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 17 minutes
                3h 17m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.