Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82282

Clicking "Flag questions" in quiz review page throws JS exception

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.3.6, 4.4.2
    • 4.3.3, 4.4.1
    • Quiz
    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MDL-82282-403
    • MDL-82282-404
    • Hide
      1. Log in as admin
      2. Create a user
      3. Create course
      4. Enrol user on course as student
      5. Add quiz activity to course
      6. Add question to quiz
      7. Press Preview quiz
      8. Press Flag question
      9. Confirm the flag icon/state is change to flagged
      10. Press Finish attempt...
      11. Press Submit all and finish and confirm the modal.
      12. On the review attept page, Press Remove flag
      13. Confirm the flag icon/state is change to not flagged
      14. Log out
      15. Log in as test user
      16. Complete the quiz as you do, re-Confirm that Flag question and Remove flag work on both the attempt and review pages as above.
      17. Log out
      18. Log in as admin
      19. Open browser developer console
      20. Navigate to quiz
      21. Press Results
      22. Press Review attempt for test user
      23. Press Flag question
      24. Confirm the flat state does not change (nothing at all should happen).
      25. Confirm no error on browser developer console
      Show
      Log in as admin Create a user Create course Enrol user on course as student Add quiz activity to course Add question to quiz Press Preview quiz Press Flag question Confirm the flag icon/state is change to flagged Press Finish attempt... Press Submit all and finish and confirm the modal. On the review attept page, Press Remove flag Confirm the flag icon/state is change to not flagged Log out Log in as test user Complete the quiz as you do, re- Confirm that Flag question and Remove flag work on both the attempt and review pages as above. Log out Log in as admin Open browser developer console Navigate to quiz Press Results Press Review attempt for test user Press Flag question Confirm the flat state does not change (nothing at all should happen). Confirm no error on browser developer console

      When attempting quiz we see the following to flag/unflag a question:

      When reviewing at attempt, we see the following (Flag question doesn't appear to be clickable):

      However clicking on it generates the following exception:

      17:14:16.719 Uncaught TypeError: input is null
          process http://moodle.internal/master/lib/javascript.php/1719245627/question/flags.js:14
          init http://moodle.internal/master/lib/javascript.php/1719245627/question/flags.js:14
          notifySub http://moodle.internal/master/theme/yui_combo.php?rollup/3.18.1/yui-moodlesimple.js:21911
          notify http://moodle.internal/master/theme/yui_combo.php?rollup/3.18.1/yui-moodlesimple.js:13789
          _notify http://moodle.internal/master/theme/yui_combo.php?rollup/3.18.1/yui-moodlesimple.js:13452
          _procSubs http://moodle.internal/master/theme/yui_combo.php?rollup/3.18.1/yui-moodlesimple.js:13578
          fireSimple http://moodle.internal/master/theme/yui_combo.php?rollup/3.18.1/yui-moodlesimple.js:13545
          _fire http://moodle.internal/master/theme/yui_combo.php?rollup/3.18.1/yui-moodlesimple.js:13527
          fire http://moodle.internal/master/theme/yui_combo.php?rollup/3.18.1/yui-moodlesimple.js:13496
          fn http://moodle.internal/master/theme/yui_combo.php?rollup/3.18.1/yui-moodlesimple.js:20472
          add http://moodle.internal/master/theme/yui_combo.php?rollup/3.18.1/yui-moodlesimple.js:185
          _createWrapper http://moodle.internal/master/theme/yui_combo.php?rollup/3.18.1/yui-moodlesimple.js:20487
          _attach http://moodle.internal/master/theme/yui_combo.php?rollup/3.18.1/yui-moodlesimple.js:20582
          delegate http://moodle.internal/master/theme/yui_combo.php?rollup/3.18.1/yui-moodlesimple.js:21853
          delegate http://moodle.internal/master/theme/yui_combo.php?rollup/3.18.1/yui-moodlesimple.js:22135
          setup http://moodle.internal/master/lib/javascript.php/1719245627/lib/javascript-static.js:86
          <anonymous> http://moodle.internal/master/mod/quiz/review.php?attempt=23:1012
          <anonymous> http://moodle.internal/master/mod/quiz/review.php?attempt=23:1014
      flags.js:14:1554
      

      We should probably only listen for those events on ".editable" instances

        1. (1) 13 Passed -- (Main)MDL-82282.png
          (1) 13 Passed -- (Main)MDL-82282.png
          67 kB
        2. (1) 16 Passed -- (Main)MDL-82282.png
          (1) 16 Passed -- (Main)MDL-82282.png
          57 kB
        3. (1) 25 Passed -- (Main)MDL-82282.png
          (1) 25 Passed -- (Main)MDL-82282.png
          143 kB
        4. (1) 9 Passed -- (Main)MDL-82282.png
          (1) 9 Passed -- (Main)MDL-82282.png
          71 kB
        5. 1.png
          1.png
          12 kB
        6. 2.png
          2.png
          10 kB

            pholden Paul Holden
            pholden Paul Holden
            Odei Alba Odei Alba
            Tim Hunt Tim Hunt
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 27 minutes
                27m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.