Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.4.2
Component/s: Course
Labels:

Affected Branches:
MOODLE_404_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.5 Branch:
MDL-82244-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-82244-405
Pull 5.0 Branch:
MDL-82244-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...paulholden:MDL-82244-500
Pull Main Branch:
MDL-82244
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-82244

Testing Instructions:

Hide

Log in as admin
Enable web services
Create custom service
Add following functions to custom service:
- core_course_create_courses
Create a token for the admin user to use the custom service
Navigate to Courses > Course default settings in site administration
Set Visible configuration to Hide

Run the following command:

$ curl --silent "<WWWROOT>/webservice/rest/server.php?moodlewsrestformat=json" --data "wstoken=<TOKEN>&wsfunction=core_course_create_courses&courses[0][fullname]=Course1&courses[0][shortname]=C1&courses[0][categoryid]=1" | python -m "json.tool"

Navigate to Courses > Manage courses and categories in site administration
Confirm Course1 is hidden (dimmed text)

Run the following command:

$ curl --silent "<WWWROOT>/webservice/rest/server.php?moodlewsrestformat=json" --data "wstoken=<TOKEN>&wsfunction=core_course_create_courses&courses[0][fullname]=Course2&courses[0][shortname]=C2&courses[0][categoryid]=1&courses[0][visible]=1" | python -m "json.tool"

Navigate to Courses > Manage courses and categories in site administration
Confirm Course 2 is visible (not dimmed text)

Show

Log in as admin Enable web services Create custom service Add following functions to custom service: core_course_create_courses Create a token for the admin user to use the custom service Navigate to Courses > Course default settings in site administration Set Visible configuration to Hide Run the following command: $ curl --silent "<WWWROOT>/webservice/rest/server.php?moodlewsrestformat=json" --data "wstoken=<TOKEN>&wsfunction=core_course_create_courses&courses[0][fullname]=Course1&courses[0][shortname]=C1&courses[0][categoryid]=1" | python -m "json.tool" Navigate to Courses > Manage courses and categories in site administration Confirm Course1 is hidden (dimmed text) Run the following command: $ curl --silent "<WWWROOT>/webservice/rest/server.php?moodlewsrestformat=json" --data "wstoken=<TOKEN>&wsfunction=core_course_create_courses&courses[0][fullname]=Course2&courses[0][shortname]=C2&courses[0][categoryid]=1&courses[0][visible]=1" | python -m "json.tool" Navigate to Courses > Manage courses and categories in site administration Confirm Course 2 is visible (not dimmed text)

Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-82244 using repository: https://github.com/paulholden/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-82244-405 | CI Job]

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-82244-500 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-82244 | CI Job]

_{More information about this report}

Built on: Thu May 29 09:46:44 UTC 2025
Show
Code verified against automated checks. Checked MDL-82244 using repository: https://github.com/paulholden/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-82244-405 | CI Job ] MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-82244-500 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-82244 | CI Job ] More information about this report Built on: Thu May 29 09:46:44 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-82244-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19518/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66750/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66751/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-82244-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19519/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66752/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66753/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-82244

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19520/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66754/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66755/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66756/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66757/ App tests (stable app version)

Built on: Thu May 29 10:25:20 UTC 2025
Show
Launching automatic jobs for branch MDL-82244 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19518/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66750/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66751/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-82244 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19519/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66752/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66753/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-82244 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19520/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66754/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66755/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66756/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66757/ App tests (stable app version) Built on: Thu May 29 10:25:20 UTC 2025

Moodle's current behavior when a course is created through the API via the core_course_create_courses function ignores the site default setting for course visibility.

The API call must include the visibile flag = 0, or else the course will be visible on creation. I find this to be counter-intuitive.

To test, make sure the default setting at admin/settings.php?section=coursesettings for course visibility is hidden.

Next, I manually created a course with the GUI and confirmed it was hidden

Then I ran two calls, one with one with no visible flag and one with the visible flag set to hidden.

[https://sandbox.moodledemo.net/webservice/rest/server.php?wsfunction=core_course_create_courses&wstoken=dfa63e90ab9a229fea70dd8c3f722315&courses[0][fullname]=API] Course No Flag&courses[0][shortname]=API1&courses[0][categoryid]=1

[https://sandbox.moodledemo.net/webservice/rest/server.php?wsfunction=core_course_create_courses&wstoken=dfa63e90ab9a229fea70dd8c3f722315&courses[0][fullname]=API] Course Visible Flag Set&courses[0][shortname]=API2&courses[0][categoryid]=1&courses[0][visible]=0

resulting in two courses - the one with no flag is visible.

I think courses created via web services should behave the same as courses created on the front end if no options are specified in the call.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

Snag_129dd7a.png
17 kB
20/Jun/24 5:21 AM

has a non-specific relationship to

MDL-83990 Courses created via webservice have a default startdate of "0"

Closed

has been marked as being related by

MDL-78381 The default admin setting course|showactivitydates is ignored in web service core_course_create_courses

Closed

Assignee:: Paul Holden

Reporter:: Benjamin Kahn

Peer reviewer:: Luca Bösch

Participants:: Benjamin Kahn, CiBoT, Luca Bösch, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 20/Jun/24 5:19 AM

Updated:: 10/Jun/25 10:13 PM

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Clockify