Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82002

Video embedding from the app is not styled properly

XMLWordPrintable

    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MDL-82002-403
    • MDL-82002-404
    • MDL-82002-main
    • Hide

      Requirements

      1. The mobile app part should be tested with the real app (the app in a browser won't work as expected for this).
      2. The Moodle site should have a public URL (ngrok or similar can be used).

      Setup

      1. As admin, enable "Mobile services":
      2. Activate the media player for Vimeo in:
        • Administration ► Plugins ► Media players ► Manage media players
      3. Search in Vimeo a video, from the share menu, get the embed code.
      4.  In Moodle go to a course and create a new page.
      5.  In the content editor, go to View → “<> Source code”
        • Paste the embed code for the Vimeo video.
        •  Save and validate its display on the web.

      Testing instructions

      1. Go to the Moodle Mobile application.
      2. Log in to the campus with a user who can access the course where we added the video.
      3.  Access the course and see how the content now expands to fill the space reserved for the video.
      Show
      Requirements The mobile app part should be tested with the real app (the app in a browser won't work as expected for this). The Moodle site should have a public URL (ngrok or similar can be used). Setup As admin, enable "Mobile services": Activate the media player for Vimeo in: Administration ► Plugins ► Media players ► Manage media players Search in Vimeo a video, from the share menu, get the embed code.  In Moodle go to a course and create a new page.  In the content editor, go to View → “<> Source code” Paste the embed code for the Vimeo video.  Save and validate its display on the web. Testing instructions Go to the Moodle Mobile application. Log in to the campus with a user who can access the course where we added the video.  Access the course and see how the content now expands to fill the space reserved for the video.

      When embedding a vimeo video from the app, the app replaces the vimeo url to a LMS url: /media/player/vimeo/wsplayer.php

      Using this the video is not properly styled and it occupies only partial place of the iframe.

      Checking the code, on wsplayer.php width and height is applied on line 66:
          $context['display'] = "position:absolute; top:0; left:0; width:100%; height:100%;";

      But checking the template (media_vimeo/appembed) display is not used but it's used style instead. #style}}style="{{style" /style

      To solve this, change $context['display'] to $context['style'].

        1. (1) 6-1 Failed -- (Main)MDL-82002.png
          (1) 6-1 Failed -- (Main)MDL-82002.png
          659 kB
        2. (1) 6-2 Failed -- (Main)MDL-82002.png
          (1) 6-2 Failed -- (Main)MDL-82002.png
          46 kB
        3. image.png
          image.png
          335 kB
        4. MDL-82002_app.jpg
          MDL-82002_app.jpg
          159 kB
        5. MDL-82002_appinbrowser.jpg
          MDL-82002_appinbrowser.jpg
          36 kB

            daniure Dani Ureña
            pferre22 Pau Ferrer
            Pau Ferrer Pau Ferrer
            Ilya Tregubov Ilya Tregubov
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 13 minutes
                2h 13m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.