Loading...

XML

Word

Printable

Affected Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE
Pull from Repository:
https://github.com/danowar2k/moodle
Pull Main Branch:
MDL-81928-master-role_parse_preset-fix
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...danowar2k:moodle:MDL-81928-master-role_parse_preset-fix
Testing Instructions:
Hide

Create a role preset XML file with attributes "unclean" name and description or with a non-existing archetype

Run a unit test on this method (Other surrounding code at least prevents creating or storing a role with a non-existing archetype to the database)
Show
Create a role preset XML file with attributes "unclean" name and description or with a non-existing archetype Run a unit test on this method (Other surrounding code at least prevents creating or storing a role with a non-existing archetype to the database)

Maybe something caused by refactoring or some such. The variable $value doesn't exist therefore is never "true".

So the cleaning/fixing is never done. I've tested a nonexisting archetype. That doesn't reach the GUI nor the database because of other code.

Anyway, it should probably be fixed.

Estimated:

Not Specified

Remaining:

Logged:

10m