Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81884

Course completion for user not shown correctly when one of 2 completions was not passed

XMLWordPrintable

    • MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE

      The calculation for the course completion status is not done correctly for the logged in user whereas in the teacher overview it is displayed correctly. The block completionstatus shows the wrong information (status pending for the logged in user instead of completed).

      When does that happen?

      This only happens in the following situation:

      1) Course completion is set to "ANY selected activities to be completed". The course completion does (only) contain "Activity completion" criteria.

      2) There are 2 graded activities (quiz), both are selected for being part in the course completion and at least one of them has to be completed

      3) The user attempts both activities, but does not achieve passing grade in one activity, but passes the second activity. Result: In the block "completionstatus" the status is pending for the affected logged in user. In the report for course completions (teacher's view), the status is "completed".

      4) The correct status is completed, because the user only has to pass 1 of 2 activities

      5) This does not happen, when one activity is completed and the second not attempted. In this case the status is correct for both logged in user and the teacher report.

      Bug must be somewhere down this line of code:

      https://github.com/moodle/moodle/blob/5f7b53980bacf4abaa8d9d1b4ab82e78c437fc7a/blocks/completionstatus/block_completionstatus.php#L105

      I think the is_pending($completion) function does not work properly (for graded completion type).

            Unassigned Unassigned
            dasistwas David Bogner
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.