Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81819

Refactor .close class renamed in Bootstrap 5

XMLWordPrintable

    • MOODLE_405_STABLE
    • MOODLE_405_STABLE
    • MDL-81819-main
    • Hide

      Setup

      1. Login as administration
      2. Create a course and a Feedback activity in it
      3. Go to Site administration > General > Advanced features and enable "enableglobalsearch"

      Test

      1. Open the messaging drawer and write a message to your own account
      2. Click on the message written
      3. Confirm that the close button is working and displayed as the following:
      4. Go to the Feedback activity in the course
      5. Click on Questions in the secondary navigation
      6. Click on Save as new template under Actions menu
      7. Confirm that the close button in the modal is working and displayed as the following:
      8. Click on Save
      9. Confirm that the close button in the alert is working and displayed as the following:

        Note that this Bug will be solved as part of MDL-81744
      10. Click on the Search icon in the navbar
      11. Confirm that the close button in the search input is working and displayed as the following:
      Show
      Setup Login as administration Create a course and a Feedback activity in it Go to Site administration > General > Advanced features and enable "enableglobalsearch" Test Open the messaging drawer and write a message to your own account Click on the message written Confirm that the close button is working and displayed as the following: Go to the Feedback activity in the course Click on Questions in the secondary navigation Click on Save as new template under Actions menu Confirm that the close button in the modal is working and displayed as the following: Click on Save Confirm that the close button in the alert is working and displayed as the following: Note that this Bug will be solved as part of MDL-81744 Click on the Search icon in the navbar Confirm that the close button in the search input is working and displayed as the following:
    • 2
    • HQ 2024 Sprint I2.3 Moppies

      In BS5 the .close class has been renamed.

      Generate the needed SCSS code in bs5bridge.scss (so we can start using BS5 syntax) and refactor all the occurrences in the codebase.

      https://getbootstrap.com/docs/5.2/migration/:

      Renamed .close to .btn-close for a less generic name.

      This issue should also be included in the BS4 compatibility layer in MDL-80519

        1. screenshot-4.png
          screenshot-4.png
          13 kB
        2. screenshot-3.png
          screenshot-3.png
          22 kB
        3. screenshot-2.png
          screenshot-2.png
          21 kB
        4. screenshot-1.png
          screenshot-1.png
          23 kB
        5. (1) 9 Passed -- (Main)MDL-81819.png
          (1) 9 Passed -- (Main)MDL-81819.png
          47 kB
        6. (1) 7 Passed -- (Main)MDL-81819.png
          (1) 7 Passed -- (Main)MDL-81819.png
          42 kB
        7. (1) 3 Passed -- (Main)MDL-81819.png
          (1) 3 Passed -- (Main)MDL-81819.png
          75 kB
        8. (1) 11 Passed -- (Main)MDL-81819.png
          (1) 11 Passed -- (Main)MDL-81819.png
          43 kB

            mikelmartíncorrales Mikel Martín Corrales
            mikelmartíncorrales Mikel Martín Corrales
            Laurent David Laurent David
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 7 hours, 28 minutes
                7h 28m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.