Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.1.11, 4.5, 4.5.4, 5.0
Component/s: Database SQL/XMLDB
Labels:
- ci
- patch

Affected Branches:
MOODLE_401_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/lucaboesch/moodle.git
Pull 4.5 Branch:
MDL-81804-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...lucaboesch:MDL-81804-405
Pull 5.0 Branch:
MDL-81804-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...lucaboesch:MDL-81804-500
Pull Main Branch:
MDL-81804-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...lucaboesch:MDL-81804-main
Testing Instructions:
Hide

One could use a pgbouncer container pointing to a PostgreSQL database, like this:

docker run --rm -e DB_USER=user -e DB_PASSWORD=pass -e DB_HOST=postgres-host -e DB_NAME=database -p 5432:5432 edoburu/pgbouncer
Show
One could use a pgbouncer container pointing to a PostgreSQL database, like this: docker run --rm -e DB_USER=user -e DB_PASSWORD=pass -e DB_HOST=postgres-host -e DB_NAME=database -p 5432:5432 edoburu/pgbouncer
Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-81804 using repository: https://github.com/lucaboesch/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-81804-405 | CI Job]

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-81804-500 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-81804-main | CI Job]

_{More information about this report}

Built on: Wed May 7 22:38:08 UTC 2025
Show
Code verified against automated checks. Checked MDL-81804 using repository: https://github.com/lucaboesch/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-81804-405 | CI Job ] MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-81804-500 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-81804-main | CI Job ] More information about this report Built on: Wed May 7 22:38:08 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-81804-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19182/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65556/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65557/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-81804-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19183/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65558/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65559/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65560/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65561/ App tests (stable app version) --> unrelated failure, please ignore.

Built on: Sun May 4 10:25:21 UTC 2025
Show
Launching automatic jobs for branch MDL-81804 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19182/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65556/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65557/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-81804 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19183/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65558/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65559/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65560/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65561/ App tests (stable app version) --> unrelated failure, please ignore. Built on: Sun May 4 10:25:21 UTC 2025

Pgbouncer after 1.20 added support for some `options` parameters, including the ones that Moodle send by default. But it does not support it in the form Moodle sends (e.g. --client_encoding=utf8). It needs to be sent in the following form: `-c client_encoding=utf8`.

We noticed this because our Moodle platform stopped working after upgrading pgbouncer.

Setting `$CFG->dboptions['dbhandlesoptions'] = true` would solve the problem, but as the 2 parameters set by Moodle (client_encoding=utf8 and standard_conforming_strings=on) are supported by pgbouncer 1.20+, a better fix would be to replace the `--key=val` by `-c key=val` variant.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

fix-pgbouncer.patch
23/May/24 7:08 PM
0.9 kB
MARCOS DOS SANTOS DE OLIVEIRA

is duplicated by

MDL-82154 Unable to install to postgres with pgbouncer

Closed

Assignee:: Unassigned

Reporter:: MARCOS DOS SANTOS DE OLIVEIRA

Peer reviewer:: Luca Bösch

Participants:: CiBoT, Jim, Luca Bösch, MARCOS DOS SANTOS DE OLIVEIRA, Simey Lameze

Votes:: 3 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 07/May/24 2:31 AM

Updated:: 13/Jun/25 4:06 PM

Estimated:

Remaining:

Logged:

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify