Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.1.10, 4.3.4, 4.4.1, 4.5
Component/s: Course
Labels:
- ci
- patch
- release_notes
- triaged

Affected Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_500_STABLE
Pull from Repository:
https://github.com/sarjona/moodle.git
Pull Main Branch:
~~MDL-81759~~-main
Pull Main Diff URL:
https://github.com/sarjona/moodle/compare/139a0ad5f0...MDL-81759-main?w=1
Testing Instructions:
Hide

Login as admin

Create a course.

Go to Course > More > Course reuse > Import

Inspect the source page and confirm the body tag contains "pagelayout-admin" instead of "pagelayout-incourse":

<body id="page-backup-import" class="[...] pagelayout-admin [...]">
Show
Login as admin Create a course. Go to Course > More > Course reuse > Import Inspect the source page and confirm the body tag contains "pagelayout-admin" instead of "pagelayout-incourse": <body id= "page-backup-import" class = "[...] pagelayout-admin [...]" >
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-81759~~ using repository: https://github.com/sarjona/moodle.git

main (0 errors / 0 warnings) [branch: MDL-81759-main | CI Job]

_{More information about this report}

Built on: Mon Feb 10 11:56:31 AM UTC 2025
Show
Code verified against automated checks. Checked MDL-81759 using repository: https://github.com/sarjona/moodle.git main (0 errors / 0 warnings) [branch: MDL-81759-main | CI Job ] More information about this report Built on: Mon Feb 10 11:56:31 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-81759~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18215/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62220/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62221/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62222/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62223/ App tests (stable app version)

Built on: Mon Feb 10 10:30:18 AM UTC 2025
Show
Launching automatic jobs for branch MDL-81759 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18215/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62220/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62221/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62222/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62223/ App tests (stable app version) Built on: Mon Feb 10 10:30:18 AM UTC 2025

In any given course:
Course > More > Course reuse > Import

In all the rest of the flows for the Course reuse, the page layout is listed as "admin", whereas in the Import flow is using the "incourse" page layout.

This makes visual customizations difficult.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 4 Passed -- (Main)MDL-81759.png
20/Feb/25 12:57 PM
134 kB
Kim Jared Lucas
0001-Update-import.php.patch
10/May/24 9:45 PM
0.8 kB
Brandon Jimenez

has a non-specific relationship to

MDL-81866 Reset: Move Reset button to sticky and improve the workflow

Closed

Assignee:: Brandon Jimenez

Reporter:: Brandon Jimenez

Peer reviewer:: Sara Arjona (@sarjona)

Integrator:: Ferran Recio

Tester:: Kim Jared Lucas

Participants:: Brandon Jimenez, CiBoT, Daniel Ziegenberg, David Woloszyn, Ferran Recio, Helen Foster, Huong Nguyen, Jun Pataleta, Kim Jared Lucas, Luca Bösch, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 16 Start watching this issue

Created:: 02/May/24 1:58 AM

Updated:: 07/Apr/25 6:24 PM

Resolved:: 21/Feb/25 11:47 AM

Estimated:

Remaining:

Logged:

48m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify