Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.7, 4.5.3
Affects Version/s: 4.4, 4.4.6, 4.5.2
Component/s: Administration
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.4 Branch:
~~MDL-81623~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-81623-404
Pull 4.5 Branch:
~~MDL-81623~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-81623-405
Pull Main Branch:
~~MDL-81623~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-81623
Testing Instructions:
Hide

Add the following to your site config.php:

$CFG->upgradekey = 'something';

Manually increase the $version value in your site version.php to induce upgrade

When prompted for upgrade key, confirm presence of visibility toggle to hide/show the field content
Show
Add the following to your site config.php : $CFG->upgradekey = 'something'; Manually increase the $version value in your site version.php to induce upgrade When prompted for upgrade key, confirm presence of visibility toggle to hide/show the field content
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-81623~~ using repository: https://github.com/paulholden/moodle/

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-81623-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-81623-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-81623 | CI Job]

_{More information about this report}

Built on: Tue Mar 4 06:05:44 UTC 2025
Show
Code verified against automated checks. Checked MDL-81623 using repository: https://github.com/paulholden/moodle/ MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-81623-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-81623-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-81623 | CI Job ] More information about this report Built on: Tue Mar 4 06:05:44 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-81623~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18377/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62942/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62943/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-81623~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18378/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62944/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62945/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-81623~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18379/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62946/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62947/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62948/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62949/ App tests (stable app version)

Built on: Thu Feb 27 22:25:20 UTC 2025
Show
Launching automatic jobs for branch MDL-81623 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18377/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62942/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62943/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-81623 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18378/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62944/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62945/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-81623 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18379/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62946/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62947/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62948/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62949/ App tests (stable app version) Built on: Thu Feb 27 22:25:20 UTC 2025

Because it'd be easier to see when I mistype/forget the upgradekey as I'm typing it

We use this elsewhere in admin settings, user login page - so let's use it here too

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-81623_404.png
15 kB
07/Mar/25 7:38 PM
MDL-81623_405.png
15 kB
07/Mar/25 7:38 PM
MDL-81623_main.png
15 kB
07/Mar/25 7:38 PM
Screen Shot 2025-02-27 at 12.23.05.png
58 kB
27/Feb/25 7:24 PM
Screenshot from 2025-01-30 13-50-47.png
10 kB
30/Jan/25 9:52 PM

has a non-specific relationship to

MDL-69353 Missing page title when prompting for upgrade key

Closed

MDL-72296 Use Bootstrap styling when prompting for upgrade key

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Daniel Ziegenberg

Integrator:: Andrew Lyons

Tester:: Sara Arjona (@sarjona)

Participants:: Andrew Lyons, CiBoT, Daniel Ziegenberg, Jun Pataleta, Paul Holden, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 22/Apr/24 8:01 PM

Updated:: 08/Mar/25 12:17 PM

Resolved:: 08/Mar/25 12:17 PM

Estimated:

Not Specified

Remaining:

Logged:

52m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify