Loading...

XML

Word

Printable

Affected Branches:
MOODLE_404_STABLE
Fixed Branches:
MOODLE_404_STABLE
Pull from Repository:
https://github.com/aolley/moodle.git
Pull Main Branch:
~~MDL-81553~~
Pull Main Diff URL:
https://github.com/aolley/moodle/compare/master...MDL-81553
Testing Instructions:
Hide

Given specific windows tests (see comments below) have passed, let's put this into automated CiBoT tests.

Verify that there aren't regressions @ CIs caused by this.

Additionally - verify ~~MDL-80553~~'s issue isn't reintroduced:

Add the grid course format (https://github.com/gjbarnard/moodle-format_grid)

Run the following PHPUnit test:

mdk phpunit -r -u backup/moodle2/tests/backup_stepslib_test.php

Check all tests pass ok.
Show
Given specific windows tests (see comments below) have passed, let's put this into automated CiBoT tests. Verify that there aren't regressions @ CIs caused by this. Additionally - verify MDL-80553 's issue isn't reintroduced: Add the grid course format ( https://github.com/gjbarnard/moodle-format_grid) Run the following PHPUnit test: mdk phpunit -r -u backup/moodle2/tests/backup_stepslib_test.php Check all tests pass ok.

~~MDL-81462~~ seems to have broken the tests added in ~~MDL-80553~~.

Destroying the backup controller before the define_structure is invoked causes the same issue 80553 was solving.

is a regression caused by

MDL-81462 Regression in backup unit tests (affecting windows)

Participants:: Adam Olley, Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Huong Nguyen, Sara Arjona (@sarjona)

Estimated:

Not Specified

Remaining:

Logged:

36m