Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.5, 4.5.1
Affects Version/s: 4.5
Component/s: Unit tests
Labels:
- ci
- triaged

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
Migrate to PHPUnit 11
Pull from Repository:
https://github.com/junpataleta/moodle.git
Pull 4.4 Branch:
~~MDL-81308~~-404
Pull 4.4 Diff URL:
https://github.com/junpataleta/moodle/compare/b097840e33...MDL-81308-404
Pull 4.5 Branch:
~~MDL-81308~~-405
Pull 4.5 Diff URL:
https://github.com/junpataleta/moodle/compare/09880d7d78...MDL-81308-405
Pull Main Branch:
~~MDL-81308~~-main
Pull Main Diff URL:
https://github.com/junpataleta/moodle/compare/ecfcf00d92...MDL-81308-main
Testing Instructions:
Hide

grep for the following:

ag '>withConsecutive' --php

ag '>willReturnOnConsecutiveCall' --php

ag '>onConsecutive' --php

Confirm no results were found
Show
grep for the following: ag '>withConsecutive' --php ag '>willReturnOnConsecutiveCall' --php ag '>onConsecutive' --php Confirm no results were found
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-81308~~ using repository: https://github.com/andrewnicols/moodle.git

main (0 errors / 0 warnings) [branch: MDL-81308-main | CI Job]

_{More information about this report}

Built on: Thu 17 Oct 2024 02:57:50 AM UTC
Show
Code verified against automated checks. Checked MDL-81308 using repository: https://github.com/andrewnicols/moodle.git main (0 errors / 0 warnings) [branch: MDL-81308-main | CI Job ] More information about this report Built on: Thu 17 Oct 2024 02:57:50 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-81308~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17094/ PHPUnit (sqlsrv / complete)

Launching automatic jobs for branch ~~MDL-81308~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17095/ PHPUnit (sqlsrv / complete)

Launching automatic jobs for branch ~~MDL-81308~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17096/ PHPUnit (sqlsrv / complete)

Built on: Wed Oct 23 06:20:22 AM UTC 2024
Show
Launching automatic jobs for branch MDL-81308 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17094/ PHPUnit (sqlsrv / complete) Launching automatic jobs for branch MDL-81308 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17095/ PHPUnit (sqlsrv / complete) Launching automatic jobs for branch MDL-81308 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17096/ PHPUnit (sqlsrv / complete) Built on: Wed Oct 23 06:20:22 AM UTC 2024

withConsecutive() was deprecated in PHPUnit 9.6 (without visible warning) and completely removed in PHPUnit 10. There is no direct replacement, but here are some ideas on how to solve this: https://github.com/sebastianbergmann/phpunit/issues/4026

We have a few instances of those...

$ ag '>withConsecutive' --php

admin/tool/dataprivacy/tests/expired_contexts_test.php

1375:            ->withConsecutive(

1593:            ->withConsecutive(

1646:            ->withConsecutive(

1865:            ->withConsecutive(

admin/tool/usertours/tests/tour_test.php

567:            ->withConsecutive(

course/tests/category_hooks_test.php

191:            ->withConsecutive(

lib/tests/content/export/exportable_items/exportable_filearea_test.php

245:            ->withConsecutive(...$storedfileargs);

lib/tests/content/export/exportable_items/exportable_textarea_test.php

331:            ->withConsecutive(...$storedfileargs);

lib/tests/completionlib_test.php

268:            ->withConsecutive(

690:            ->withConsecutive(

1178:            ->withConsecutive(

repository/dropbox/tests/api_test.php

423:            ->withConsecutive(['testEndpoint'], ['testEndpoint/continue'], ['testEndpoint/continue'])

478:            ->withConsecutive(

557:            ->withConsecutive(

596:            ->withConsecutive(

repository/googledocs/tests/googledocs_search_content_test.php

69:            ->withConsecutive(

repository/googledocs/tests/local/browser/googledocs_drive_content_test.php

68:            ->withConsecutive(

completion/tests/activity_custom_completion_test.php

106:                ->withConsecutive(

In this issue we should:

Decide the target for the fix: Moodle 4.4 with PHPUnit 9.6 vs future Moodle version with PHPUnit 10.
Look how many of the uses detected are really useful, there is a lot of debate about when this sort of mocking is correct or no. Maybe we can reduce the uses.
No matter the previous point, for sure some of the cases will need to be converted to some alternative, that can be:
1. Create some trait providing an in-place (or near in-place) replacement.
2. Add support from advanced_testcase or similar.
3. Other, custom, working replacements, case by case.
4. ...

blocks

MDL-83468 Bump to PHPUnit 11

Closed

has been marked as being related by

MDL-81266 Bump behat and phpunit (composer) to current ones (PHP 8.3 / Moodle 4.4)

Closed

Assignee:: Andrew Lyons

Reporter:: Daniel Ziegenberg

Peer reviewer:: Paul Holden

Integrator:: Jun Pataleta

Tester:: Jun Pataleta

Participants:: Andrew Lyons, CiBoT, Daniel Ziegenberg, Jun Pataleta, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 21/Mar/24 3:00 AM

Updated:: 25/Oct/24 10:34 AM

Resolved:: 25/Oct/24 10:34 AM

Estimated:

Not Specified

Remaining:

Logged:

1h 44m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify